Skip to content

Commit 87b4c42

Browse files
committed
Explicit LooseVersion comps
1 parent 13f6267 commit 87b4c42

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+107
-98
lines changed

pandas/_libs/sparse.pyx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ from distutils.version import LooseVersion
1212

1313
# numpy versioning
1414
_np_version = np.version.short_version
15-
_np_version_under1p10 = LooseVersion(_np_version) < '1.10'
16-
_np_version_under1p11 = LooseVersion(_np_version) < '1.11'
15+
_np_version_under1p10 = LooseVersion(_np_version) < LooseVersion('1.10')
16+
_np_version_under1p11 = LooseVersion(_np_version) < LooseVersion('1.11')
1717

1818
np.import_array()
1919
np.import_ufunc()

pandas/compat/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ def raise_with_traceback(exc, traceback=Ellipsis):
399399
# dateutil minimum version
400400
import dateutil
401401

402-
if LooseVersion(dateutil.__version__) < '2.5':
402+
if LooseVersion(dateutil.__version__) < LooseVersion('2.5'):
403403
raise ImportError('dateutil 2.5.0 is the minimum required version')
404404
from dateutil import parser as _date_parser
405405
parse_date = _date_parser.parse

pandas/compat/numpy/__init__.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99
# numpy versioning
1010
_np_version = np.__version__
1111
_nlv = LooseVersion(_np_version)
12-
_np_version_under1p10 = _nlv < '1.10'
13-
_np_version_under1p11 = _nlv < '1.11'
14-
_np_version_under1p12 = _nlv < '1.12'
15-
_np_version_under1p13 = _nlv < '1.13'
16-
_np_version_under1p14 = _nlv < '1.14'
17-
_np_version_under1p15 = _nlv < '1.15'
12+
_np_version_under1p10 = _nlv < LooseVersion('1.10')
13+
_np_version_under1p11 = _nlv < LooseVersion('1.11')
14+
_np_version_under1p12 = _nlv < LooseVersion('1.12')
15+
_np_version_under1p13 = _nlv < LooseVersion('1.13')
16+
_np_version_under1p14 = _nlv < LooseVersion('1.14')
17+
_np_version_under1p15 = _nlv < LooseVersion('1.15')
1818

1919
if _nlv < '1.9':
2020
raise ImportError('this version of pandas is incompatible with '

pandas/conftest.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ def ip():
7070

7171

7272
is_dateutil_le_261 = pytest.mark.skipif(
73-
LooseVersion(dateutil.__version__) > '2.6.1',
73+
LooseVersion(dateutil.__version__) > LooseVersion('2.6.1'),
7474
reason="dateutil api change version")
7575
is_dateutil_gt_261 = pytest.mark.skipif(
76-
LooseVersion(dateutil.__version__) <= '2.6.1',
76+
LooseVersion(dateutil.__version__) <= LooseVersion('2.6.1'),
7777
reason="dateutil stable version")

pandas/core/computation/check.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
try:
88
import numexpr as ne
9-
ver = ne.__version__
9+
ver = LooseVersion(ne.__version__)
1010
_NUMEXPR_INSTALLED = ver >= LooseVersion(_MIN_NUMEXPR_VERSION)
1111

1212
if not _NUMEXPR_INSTALLED:

pandas/core/missing.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ def _from_derivatives(xi, yi, x, order=None, der=0, extrapolate=False):
347347
import scipy
348348
from scipy import interpolate
349349

350-
if LooseVersion(scipy.__version__) < '0.18.0':
350+
if LooseVersion(scipy.__version__) < LooseVersion('0.18.0'):
351351
try:
352352
method = interpolate.piecewise_polynomial_interpolate
353353
return method(xi, yi.reshape(-1, 1), x,

pandas/io/feather_format.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def _try_import():
2222
"pip install -U feather-format\n")
2323

2424
try:
25-
feather.__version__ >= LooseVersion('0.3.1')
25+
LooseVersion(feather.__version__) >= LooseVersion('0.3.1')
2626
except AttributeError:
2727
raise ImportError("the feather-format library must be >= "
2828
"version 0.3.1\n"
@@ -106,7 +106,7 @@ def read_feather(path, nthreads=1):
106106
feather = _try_import()
107107
path = _stringify_path(path)
108108

109-
if feather.__version__ < LooseVersion('0.4.0'):
109+
if LooseVersion(feather.__version__) < LooseVersion('0.4.0'):
110110
return feather.read_dataframe(path)
111111

112112
return feather.read_dataframe(path, nthreads=nthreads)

pandas/io/html.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -684,7 +684,7 @@ def _parser_dispatch(flavor):
684684
raise ImportError(
685685
"BeautifulSoup4 (bs4) not found, please install it")
686686
import bs4
687-
if bs4.__version__ == LooseVersion('4.2.0'):
687+
if LooseVersion(bs4.__version__) == LooseVersion('4.2.0'):
688688
raise ValueError("You're using a version"
689689
" of BeautifulSoup4 (4.2.0) that has been"
690690
" known to cause problems on certain"

pandas/io/parquet.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,18 @@ def __init__(self):
5050
"\nor via pip\n"
5151
"pip install -U pyarrow\n")
5252

53-
if LooseVersion(pyarrow.__version__) < '0.4.1':
53+
if LooseVersion(pyarrow.__version__) < LooseVersion('0.4.1'):
5454
raise ImportError("pyarrow >= 0.4.1 is required for parquet"
5555
"support\n\n"
5656
"you can install via conda\n"
5757
"conda install pyarrow -c conda-forge\n"
5858
"\nor via pip\n"
5959
"pip install -U pyarrow\n")
6060

61-
self._pyarrow_lt_050 = LooseVersion(pyarrow.__version__) < '0.5.0'
62-
self._pyarrow_lt_060 = LooseVersion(pyarrow.__version__) < '0.6.0'
61+
self._pyarrow_lt_050 = (LooseVersion(pyarrow.__version__) <
62+
LooseVersion('0.5.0'))
63+
self._pyarrow_lt_060 = (LooseVersion(pyarrow.__version__) <
64+
LooseVersion('0.6.0'))
6365
self.api = pyarrow
6466

6567
def write(self, df, path, compression='snappy',
@@ -97,7 +99,7 @@ def __init__(self):
9799
"\nor via pip\n"
98100
"pip install -U fastparquet")
99101

100-
if LooseVersion(fastparquet.__version__) < '0.1.0':
102+
if LooseVersion(fastparquet.__version__) < LooseVersion('0.1.0'):
101103
raise ImportError("fastparquet >= 0.1.0 is required for parquet "
102104
"support\n\n"
103105
"you can install via conda\n"

pandas/io/pytables.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def _tables():
248248
_table_mod = tables
249249

250250
# version requirements
251-
if LooseVersion(tables.__version__) < '3.0.0':
251+
if LooseVersion(tables.__version__) < LooseVersion('3.0.0'):
252252
raise ImportError("PyTables version >= 3.0.0 is required")
253253

254254
# set the file open policy

0 commit comments

Comments
 (0)