Skip to content

Commit 7c3a305

Browse files
committed
Add changes from reviewer
1 parent 9ee53bd commit 7c3a305

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

doc/source/whatsnew/v0.24.0.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ See the :ref:`Advanced documentation on renaming<advanced.index_names>` for more
362362
Other Enhancements
363363
^^^^^^^^^^^^^^^^^^
364364

365-
- Added support for %G strptime directive in parsing datetimes
365+
- Added support for ISO week year format when parsing datetimes using `to_datetime` (:issue:`16607`)
366366
- :func:`merge` now directly allows merge between objects of type ``DataFrame`` and named ``Series``, without the need to convert the ``Series`` object into a ``DataFrame`` beforehand (:issue:`21220`)
367367
- ``ExcelWriter`` now accepts ``mode`` as a keyword argument, enabling append to existing workbooks when using the ``openpyxl`` engine (:issue:`3441`)
368368
- ``FrozenList`` has gained the ``.union()`` and ``.difference()`` methods. This functionality greatly simplifies groupby's that rely on explicitly excluding certain columns. See :ref:`Splitting an object into groups <groupby.split>` for more information (:issue:`15475`, :issue:`15506`).

pandas/tests/indexes/datetimes/test_tools.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,7 @@ class TestToDatetime(object):
253253
['2015-1-7', '%G-%V-%u', datetime(2015, 1, 4, 0, 0)]
254254
])
255255
def test_to_datetime_iso_week_year_format(self, s, _format, dt):
256+
# See GH#16607
256257
assert to_datetime(s, format=_format) == dt
257258

258259
@pytest.mark.parametrize("msg, s, _format", [
@@ -291,6 +292,7 @@ def test_to_datetime_iso_week_year_format(self, s, _format, dt):
291292
"'%G' and a weekday directive '%A', '%a', '%w', or '%u'.", "20", "%V"]
292293
])
293294
def test_ValueError_iso_week_year(self, msg, s, _format):
295+
# See GH#16607
294296
with pytest.raises(ValueError, message=msg):
295297
to_datetime(s, format=_format)
296298

0 commit comments

Comments
 (0)