no-unsafe-any: correctly handle types and type-only namespaces (#3487)

Author: ajafff

src/rules/noUnsafeAnyRule.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { isReassignmentTarget, isTokenKind, isTypeFlagSet, isTypeNodeKind } from "tsutils";
+import { isReassignmentTarget, isSymbolFlagSet, isTokenKind, isTypeFlagSet, isTypeNodeKind } from "tsutils";
 import * as ts from "typescript";
 import * as Lint from "../index";
 
@@ -365,6 +365,19 @@ function isPropertyAny(node: ts.PropertyDeclaration, checker: ts.TypeChecker) {
 }
 
 function isNodeAny(node: ts.Node, checker: ts.TypeChecker): boolean {
+    let symbol = checker.getSymbolAtLocation(node);
+    if (symbol !== undefined && isSymbolFlagSet(symbol, ts.SymbolFlags.Alias)) {
+        symbol = checker.getAliasedSymbol(symbol);
+    }
+    if (symbol !== undefined) {
+        // NamespaceModule is a type-only namespace without runtime value, its type is 'any' when used as 'ns.Type' -> avoid error
+        if (isSymbolFlagSet(symbol, ts.SymbolFlags.NamespaceModule)) {
+            return false;
+        }
+        if (isSymbolFlagSet(symbol, ts.SymbolFlags.Type)) {
+            return isAny(checker.getDeclaredTypeOfSymbol(symbol));
+        }
+    }
     return isAny(checker.getTypeAtLocation(node));
 }
 

test/rules/no-unsafe-any/es6Module.ts

@@ -2,3 +2,7 @@ const defaultExport: any = 0;
 export default defaultExport;
 export const namedExport: any = 0;
 export type T = number;
+
+export namespace NS {
+    export interface ITest {}
+}

test/rules/no-unsafe-any/test.ts.lint

@@ -3,7 +3,8 @@ import importAlias = importEquals;
 namespace N { export const x: any = 0; }
 import importQualifiedName = N.x;
 import * as namespaceImport from "./es6Module";
-import defaultExport, { namedExport } from "./es6Module";
+import defaultExport, { namedExport, NS } from "./es6Module";
+import namedExportAlias = namespaceImport.namedExport;
 
 const num: namespaceImport.T = 0;
 
@@ -30,11 +31,14 @@ label: while(true) {
 }
 
 importAlias.property;
-~~~~~~~~~~~ [0]
 
 namespaceImport.namedExport;
 
-importAlias, importAlias;
+namedExport.foo;
+~~~~~~~~~~~ [0]
+namedExportAlias.foo;
+~~~~~~~~~~~~~~~~ [0]
+namedExport, namedExportAlias;
 
 
 declare const x: any;
@@ -319,4 +323,26 @@ function hasThisParameter(this: any) {
                  ~ [0]
 }
 
+namespace TestNS {
+    export interface ITest {}
+}
+namespace TestNS2 {
+    "";
+    export interface ITest {}
+}
+{
+    class Test implements TestNS.ITest {}
+    type T = any;
+    class Test2 implements T {}
+                           ~ [0]
+    let C = null as any;
+    class Test3 extends C {}
+                        ~ [0]
+
+    interface I {}
+    class Test4 implements I {}
+    class Test5 implements TestNS2.ITest {}
+    class Test6 implements NS.ITest {}
+}
+
 [0]: Unsafe use of expression of type 'any'.