Skip to content

remove strict parsing#95

Merged
deitch merged 2 commits intomasterfrom
non-strict-yaml
Nov 4, 2020
Merged

remove strict parsing#95
deitch merged 2 commits intomasterfrom
non-strict-yaml

Conversation

@deitch
Copy link
Contributor

@deitch deitch commented Nov 4, 2020

Fixes #93

@deitch
remove strict parsing
c1af20d 
Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch deitch requested a review from displague November 4, 2020 13:21
displague
displague approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@displague displague left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

I'm curious about which fields were not mapped or were duplicated? Should they be better handled or are they extraneous to our needs?

@deitch
Copy link
Contributor Author

deitch commented Nov 4, 2020

I'm curious about which fields were not mapped or were duplicated? Should they be better handled or are they extraneous to our needs?

Extraneous to our needs. Some of the Kinvolk folk extend the configmap. No reason we should break on that, we can be expansive 😀

@deitch deitch merged commit f669a86 into master Nov 4, 2020
@deitch deitch deleted the non-strict-yaml branch November 4, 2020 17:58
@knrt10 knrt10 mentioned this pull request Nov 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@displague displague displague approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

re-applying Lokomotive's MetalLB fails ccm

2 participants

@deitch @displague