[meta] update rust to 1.84 (#7334)

We're moving three versions ahead, so this is something we should do
with some caution. However there's at least one important
illumos-specific fix that's in 1.84
(rust-lang/rust#132984) so we should definitely
move over.

I've verified that rust-lang/rust#132064 no
longer affects us. To be more precise, its impact has been mostly taken
care of -- there's still a small regression, see [this
comment](rust-lang/rust#132064 (comment)),
but the Rust team has said it's one that should get better in the next
few months.

Author: sunshowers

clients/dpd-client/src/lib.rs

@@ -9,8 +9,6 @@
 // That test passes for code that lives in omicron, but fails for code imported
 // by omicron.
 #![allow(rustdoc::broken_intra_doc_links)]
-// Temporary workaround while Rust is being updated to 1.84.
-#![allow(unknown_lints)]
 
 use std::net::IpAddr;
 

cockroach-admin/types/src/lib.rs

@@ -75,7 +75,7 @@ where
     D: serde::Deserializer<'de>,
 {
     struct CockroachTimestampVisitor;
-    impl<'de> de::Visitor<'de> for CockroachTimestampVisitor {
+    impl de::Visitor<'_> for CockroachTimestampVisitor {
         type Value = DateTime<Utc>;
 
         fn expecting(
@@ -185,7 +185,7 @@ where
 {
     struct CockroachNodeMembershipVisitor;
 
-    impl<'de> de::Visitor<'de> for CockroachNodeMembershipVisitor {
+    impl de::Visitor<'_> for CockroachNodeMembershipVisitor {
         type Value = NodeMembership;
 
         fn expecting(

common/src/api/external/error.rs

@@ -147,7 +147,7 @@ impl MessagePair {
 
 struct MessagePairDisplayInternal<'a>(&'a MessagePair);
 
-impl<'a> Display for MessagePairDisplayInternal<'a> {
+impl Display for MessagePairDisplayInternal<'_> {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         write!(f, "{}", self.0.external_message)?;
         if !self.0.internal_context.is_empty() {

dev-tools/downloader/src/lib.rs

@@ -458,7 +458,7 @@ async fn download_file_and_verify(
     Ok(())
 }
 
-impl<'a> Downloader<'a> {
+impl Downloader<'_> {
     async fn download_cargo_hack(&self) -> Result<()> {
         let os = os_name()?;
         let arch = arch()?;

dev-tools/omdb/src/bin/omdb/mgs.rs

@@ -197,7 +197,7 @@ fn show_sp_ids(sp_ids: &[SpIdentifier]) -> Result<(), anyhow::Error> {
         slot: u32,
     }
 
-    impl<'a> From<&'a SpIdentifier> for SpIdRow {
+    impl From<&SpIdentifier> for SpIdRow {
         fn from(id: &SpIdentifier) -> Self {
             SpIdRow { type_: sp_type_to_str(&id.type_), slot: id.slot }
         }
@@ -224,7 +224,7 @@ fn show_sps_from_ignition(
         system_type: String,
     }
 
-    impl<'a> From<&'a SpIgnitionInfo> for IgnitionRow {
+    impl From<&SpIgnitionInfo> for IgnitionRow {
         fn from(value: &SpIgnitionInfo) -> Self {
             IgnitionRow {
                 type_: sp_type_to_str(&value.id.type_),

dev-tools/releng/src/job.rs

@@ -164,7 +164,7 @@ impl Job {
     }
 }
 
-impl<'a> Selector<'a> {
+impl Selector<'_> {
     #[track_caller]
     pub(crate) fn after(self, other: impl AsRef<str>) -> Self {
         let (sender, receiver) = oneshot::channel();

dns-server/src/storage.rs

@@ -711,7 +711,7 @@ struct UpdateGuard<'store, 'req_id> {
     finished: bool,
 }
 
-impl<'a, 'b> UpdateGuard<'a, 'b> {
+impl UpdateGuard<'_, '_> {
     async fn finish(mut self) {
         let store = self.store;
         let mut update = store.updating.lock().await;
@@ -732,7 +732,7 @@ impl<'a, 'b> UpdateGuard<'a, 'b> {
     }
 }
 
-impl<'a, 'b> Drop for UpdateGuard<'a, 'b> {
+impl Drop for UpdateGuard<'_, '_> {
     fn drop(&mut self) {
         // UpdateGuard exists because we must enforce at most one Update is
         // happening at a time, but we also want to catch the case where an

illumos-utils/src/svc.rs

@@ -25,9 +25,15 @@ mod inner {
     // properties to not exist when the command returns.
     //
     // We workaround this by querying for these properties in a loop.
-    pub async fn wait_for_service<'a, 'b>(
+    //
+    // TODO: remove this when clippy no longer flags
+    // https://github.com/rust-lang/rust-clippy/issues/13923 (ideally we'd have
+    // used `expect` but on 1.84, it says that it's unfulfilled even though it
+    // is fulfilled?)
+    #[allow(clippy::needless_lifetimes)]
+    pub async fn wait_for_service<'a>(
         zone: Option<&'a str>,
-        fmri: &'b str,
+        fmri: &str,
         log: Logger,
     ) -> Result<(), Error> {
         let name = smf::PropertyName::new("restarter", "state").unwrap();

installinator/src/write.rs

@@ -352,7 +352,7 @@ struct SlotWriteContext<'a> {
     progress: DriveWriteProgress,
 }
 
-impl<'a> SlotWriteContext<'a> {
+impl SlotWriteContext<'_> {
     fn register_steps<'b>(
         &'b self,
         engine: &UpdateEngine<'b, WriteSpec>,
@@ -518,12 +518,12 @@ struct ArtifactsToWrite<'a> {
 
 impl ArtifactsToWrite<'_> {
     /// Attempt to write the host phase 2 image.
-    async fn write_host_phase_2<'b, WT: WriteTransport>(
+    async fn write_host_phase_2<WT: WriteTransport>(
         &self,
         log: &Logger,
         slot: M2Slot,
         destinations: &ArtifactDestination,
-        transport: &'b mut WT,
+        transport: &mut WT,
         cx: &StepContext<WriteSpec>,
     ) -> Result<StepResult<Option<usize>, WriteSpec>, WriteError> {
         let block_size = write_artifact_impl(

internal-dns/types/src/diff.rs

@@ -136,7 +136,7 @@ impl<'a> DnsDiff<'a> {
     }
 }
 
-impl<'a> std::fmt::Display for DnsDiff<'a> {
+impl std::fmt::Display for DnsDiff<'_> {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         let names_changed = !self.is_empty();
         let zone_name = &self.zone_name;