perf(linter): replace phf_set with array in globals.rs (#10483)

shulaoda · shulaoda · commit d4033bc2552c · 2025-04-17T20:04:54.000Z
Related to #10076
diff --git a/crates/oxc_linter/src/globals.rs b/crates/oxc_linter/src/globals.rs
@@ -1,5 +1,3 @@
-use phf::phf_set;
-
 pub const GLOBAL_OBJECT_NAMES: [&str; 4] = ["global", "globalThis", "self", "window"];
 
 /// set of reserved HTML tag names definition
@@ -192,135 +190,135 @@ pub fn is_valid_aria_property(name: &str) -> bool {
 /// set of valid ARIA role definitions
 /// Reference: <https://www.w3.org/TR/wai-aria/#role_definitions>
 /// Reference: <https://github.com/A11yance/aria-query/blob/v5.3.2/src/rolesMap.js>
-pub const VALID_ARIA_ROLES: phf::Set<&'static str> = phf_set! {
-  "alert",
-  "alertdialog",
-  "application",
-  "article",
-  "banner",
-  "blockquote",
-  "button",
-  "caption",
-  "cell",
-  "checkbox",
-  "code",
-  "columnheader",
-  "combobox",
-  "complementary",
-  "contentinfo",
-  "definition",
-  "deletion",
-  "dialog",
-  "directory",
-  "doc-abstract",
-  "doc-acknowledgments",
-  "doc-afterword",
-  "doc-appendix",
-  "doc-backlink",
-  "doc-biblioentry",
-  "doc-bibliography",
-  "doc-biblioref",
-  "doc-chapter",
-  "doc-colophon",
-  "doc-conclusion",
-  "doc-cover",
-  "doc-credit",
-  "doc-credits",
-  "doc-dedication",
-  "doc-endnote",
-  "doc-endnotes",
-  "doc-epigraph",
-  "doc-epilogue",
-  "doc-errata",
-  "doc-example",
-  "doc-footnote",
-  "doc-foreword",
-  "doc-glossary",
-  "doc-glossref",
-  "doc-index",
-  "doc-introduction",
-  "doc-noteref",
-  "doc-notice",
-  "doc-pagebreak",
-  "doc-pagelist",
-  "doc-part",
-  "doc-preface",
-  "doc-prologue",
-  "doc-pullquote",
-  "doc-qna",
-  "doc-subtitle",
-  "doc-tip",
-  "doc-toc",
-  "document",
-  "emphasis",
-  "feed",
-  "figure",
-  "form",
-  "generic",
-  "graphics-document",
-  "graphics-object",
-  "graphics-symbol",
-  "grid",
-  "gridcell",
-  "group",
-  "heading",
-  "img",
-  "insertion",
-  "link",
-  "list",
-  "listbox",
-  "listitem",
-  "log",
-  "main",
-  "mark",
-  "marquee",
-  "math",
-  "menu",
-  "menubar",
-  "menuitem",
-  "menuitemcheckbox",
-  "menuitemradio",
-  "meter",
-  "navigation",
-  "none",
-  "note",
-  "option",
-  "paragraph",
-  "presentation",
-  "progressbar",
-  "radio",
-  "radiogroup",
-  "region",
-  "row",
-  "rowgroup",
-  "rowheader",
-  "scrollbar",
-  "search",
-  "searchbox",
-  "separator",
-  "slider",
-  "spinbutton",
-  "status",
-  "strong",
-  "subscript",
-  "superscript",
-  "switch",
-  "tab",
-  "table",
-  "tablist",
-  "tabpanel",
-  "term",
-  "textbox",
-  "time",
-  "timer",
-  "toolbar",
-  "tooltip",
-  "tree",
-  "treegrid",
-  "treeitem"
-};
+pub const VALID_ARIA_ROLES: [&str; 125] = [
+    "alert",
+    "alertdialog",
+    "application",
+    "article",
+    "banner",
+    "blockquote",
+    "button",
+    "caption",
+    "cell",
+    "checkbox",
+    "code",
+    "columnheader",
+    "combobox",
+    "complementary",
+    "contentinfo",
+    "definition",
+    "deletion",
+    "dialog",
+    "directory",
+    "doc-abstract",
+    "doc-acknowledgments",
+    "doc-afterword",
+    "doc-appendix",
+    "doc-backlink",
+    "doc-biblioentry",
+    "doc-bibliography",
+    "doc-biblioref",
+    "doc-chapter",
+    "doc-colophon",
+    "doc-conclusion",
+    "doc-cover",
+    "doc-credit",
+    "doc-credits",
+    "doc-dedication",
+    "doc-endnote",
+    "doc-endnotes",
+    "doc-epigraph",
+    "doc-epilogue",
+    "doc-errata",
+    "doc-example",
+    "doc-footnote",
+    "doc-foreword",
+    "doc-glossary",
+    "doc-glossref",
+    "doc-index",
+    "doc-introduction",
+    "doc-noteref",
+    "doc-notice",
+    "doc-pagebreak",
+    "doc-pagelist",
+    "doc-part",
+    "doc-preface",
+    "doc-prologue",
+    "doc-pullquote",
+    "doc-qna",
+    "doc-subtitle",
+    "doc-tip",
+    "doc-toc",
+    "document",
+    "emphasis",
+    "feed",
+    "figure",
+    "form",
+    "generic",
+    "graphics-document",
+    "graphics-object",
+    "graphics-symbol",
+    "grid",
+    "gridcell",
+    "group",
+    "heading",
+    "img",
+    "insertion",
+    "link",
+    "list",
+    "listbox",
+    "listitem",
+    "log",
+    "main",
+    "mark",
+    "marquee",
+    "math",
+    "menu",
+    "menubar",
+    "menuitem",
+    "menuitemcheckbox",
+    "menuitemradio",
+    "meter",
+    "navigation",
+    "none",
+    "note",
+    "option",
+    "paragraph",
+    "presentation",
+    "progressbar",
+    "radio",
+    "radiogroup",
+    "region",
+    "row",
+    "rowgroup",
+    "rowheader",
+    "scrollbar",
+    "search",
+    "searchbox",
+    "separator",
+    "slider",
+    "spinbutton",
+    "status",
+    "strong",
+    "subscript",
+    "superscript",
+    "switch",
+    "tab",
+    "table",
+    "tablist",
+    "tabpanel",
+    "term",
+    "textbox",
+    "time",
+    "timer",
+    "toolbar",
+    "tooltip",
+    "tree",
+    "treegrid",
+    "treeitem",
+];
 
-pub const HTML_TAG: phf::Set<&'static str> = phf_set! {
+pub const HTML_TAG: [&str; 149] = [
     "a",
     "abbr",
     "acronym",
@@ -470,4 +468,4 @@ pub const HTML_TAG: phf::Set<&'static str> = phf_set! {
     "video",
     "wbr",
     "xmp",
-};
+];
diff --git a/crates/oxc_linter/src/rules/jsx_a11y/aria_activedescendant_has_tabindex.rs b/crates/oxc_linter/src/rules/jsx_a11y/aria_activedescendant_has_tabindex.rs
@@ -67,7 +67,7 @@ impl Rule for AriaActivedescendantHasTabindex {
 
         let element_type = get_element_type(ctx, jsx_opening_el);
 
-        if !HTML_TAG.contains(&element_type) {
+        if HTML_TAG.binary_search(&element_type.as_ref()).is_err() {
             return;
         }
 
diff --git a/crates/oxc_linter/src/rules/jsx_a11y/aria_role.rs b/crates/oxc_linter/src/rules/jsx_a11y/aria_role.rs
@@ -146,7 +146,7 @@ impl Rule for AriaRole {
             if let Some(aria_role) = has_jsx_prop(&jsx_el.opening_element, "role") {
                 let element_type = get_element_type(ctx, &jsx_el.opening_element);
 
-                if self.ignore_non_dom && !HTML_TAG.contains(&element_type) {
+                if self.ignore_non_dom && HTML_TAG.binary_search(&element_type.as_ref()).is_err() {
                     return;
                 }
 
diff --git a/crates/oxc_linter/src/rules/jsx_a11y/click_events_have_key_events.rs b/crates/oxc_linter/src/rules/jsx_a11y/click_events_have_key_events.rs
@@ -62,7 +62,7 @@ impl Rule for ClickEventsHaveKeyEvents {
         // Check only native DOM elements or custom component via settings
         let element_type = get_element_type(ctx, jsx_opening_el);
 
-        if !HTML_TAG.contains(&element_type) {
+        if HTML_TAG.binary_search(&element_type.as_ref()).is_err() {
             return;
         }
 
diff --git a/crates/oxc_linter/src/rules/jsx_a11y/mouse_events_have_key_events.rs b/crates/oxc_linter/src/rules/jsx_a11y/mouse_events_have_key_events.rs
@@ -105,7 +105,7 @@ impl Rule for MouseEventsHaveKeyEvents {
 
         let el_type = get_element_type(ctx, jsx_opening_el);
 
-        if !HTML_TAG.contains(&el_type) {
+        if HTML_TAG.binary_search(&el_type.as_ref()).is_err() {
             return;
         }
 
diff --git a/crates/oxc_linter/src/rules/jsx_a11y/no_autofocus.rs b/crates/oxc_linter/src/rules/jsx_a11y/no_autofocus.rs
@@ -105,7 +105,7 @@ impl Rule for NoAutofocus {
         let element_type = get_element_type(ctx, &jsx_el.opening_element);
 
         if self.ignore_non_dom {
-            if HTML_TAG.contains(&element_type) {
+            if HTML_TAG.binary_search(&element_type.as_ref()).is_ok() {
                 if let JSXAttributeItem::Attribute(attr) = autofocus {
                     ctx.diagnostic_with_fix(no_autofocus_diagnostic(attr.span), |fixer| {
                         fixer.delete(&attr.span)
diff --git a/crates/oxc_linter/src/rules/jsx_a11y/role_supports_aria_props.rs b/crates/oxc_linter/src/rules/jsx_a11y/role_supports_aria_props.rs
@@ -78,7 +78,7 @@ impl Rule for RoleSupportsAriaProps {
         );
         let is_implicit = role_value.is_some() && role.is_none();
         if let Some(role_value) = role_value {
-            if !VALID_ARIA_ROLES.contains(role_value) {
+            if VALID_ARIA_ROLES.binary_search(&role_value).is_err() {
                 return;
             }
             for attr in &jsx_el.attributes {
@@ -157,7 +157,7 @@ fn get_implicit_role<'a>(
         _ => "",
     };
 
-    if VALID_ARIA_ROLES.contains(implicit_role) { Some(implicit_role) } else { None }
+    VALID_ARIA_ROLES.binary_search(&implicit_role).is_ok().then_some(implicit_role)
 }
 
 const ALERT_ETC_PROPS: &[AriaProperty] = &[
diff --git a/crates/oxc_linter/src/rules/jsx_a11y/scope.rs b/crates/oxc_linter/src/rules/jsx_a11y/scope.rs
@@ -72,7 +72,7 @@ impl Rule for Scope {
             return;
         }
 
-        if !HTML_TAG.contains(&element_type) {
+        if HTML_TAG.binary_search(&element_type.as_ref()).is_err() {
             return;
         }
 
diff --git a/crates/oxc_linter/src/rules/react/self_closing_comp.rs b/crates/oxc_linter/src/rules/react/self_closing_comp.rs
@@ -116,7 +116,7 @@ impl Rule for SelfClosingComp {
         let mut is_dom_comp = false;
         if !is_comp {
             if let Some(tag_name) = jsx_el.opening_element.name.get_identifier_name() {
-                is_dom_comp = HTML_TAG.contains(&tag_name);
+                is_dom_comp = HTML_TAG.binary_search(&tag_name.as_str()).is_ok();
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ impl Rule for AriaActivedescendantHasTabindex {`
`67`	`67`
`68`	`68`	`let element_type = get_element_type(ctx, jsx_opening_el);`
`69`	`69`
`70`		`- if !HTML_TAG.contains(&element_type) {`
	`70`	`+ if HTML_TAG.binary_search(&element_type.as_ref()).is_err() {`
`71`	`71`	`return;`
`72`	`72`	`}`
`73`	`73`
Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ impl Rule for AriaRole {`
`146`	`146`	`if let Some(aria_role) = has_jsx_prop(&jsx_el.opening_element, "role") {`
`147`	`147`	`let element_type = get_element_type(ctx, &jsx_el.opening_element);`
`148`	`148`
`149`		`- if self.ignore_non_dom && !HTML_TAG.contains(&element_type) {`
	`149`	`+ if self.ignore_non_dom && HTML_TAG.binary_search(&element_type.as_ref()).is_err() {`
`150`	`150`	`return;`
`151`	`151`	`}`
`152`	`152`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ impl Rule for ClickEventsHaveKeyEvents {`
`62`	`62`	`// Check only native DOM elements or custom component via settings`
`63`	`63`	`let element_type = get_element_type(ctx, jsx_opening_el);`
`64`	`64`
`65`		`- if !HTML_TAG.contains(&element_type) {`
	`65`	`+ if HTML_TAG.binary_search(&element_type.as_ref()).is_err() {`
`66`	`66`	`return;`
`67`	`67`	`}`
`68`	`68`
Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ impl Rule for MouseEventsHaveKeyEvents {`
`105`	`105`
`106`	`106`	`let el_type = get_element_type(ctx, jsx_opening_el);`
`107`	`107`
`108`		`- if !HTML_TAG.contains(&el_type) {`
	`108`	`+ if HTML_TAG.binary_search(&el_type.as_ref()).is_err() {`
`109`	`109`	`return;`
`110`	`110`	`}`
`111`	`111`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ impl Rule for Scope {`
`72`	`72`	`return;`
`73`	`73`	`}`
`74`	`74`
`75`		`- if !HTML_TAG.contains(&element_type) {`
	`75`	`+ if HTML_TAG.binary_search(&element_type.as_ref()).is_err() {`
`76`	`76`	`return;`
`77`	`77`	`}`
`78`	`78`
Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ impl Rule for SelfClosingComp {`
`116`	`116`	`let mut is_dom_comp = false;`
`117`	`117`	`if !is_comp {`
`118`	`118`	`if let Some(tag_name) = jsx_el.opening_element.name.get_identifier_name() {`
`119`		`- is_dom_comp = HTML_TAG.contains(&tag_name);`
	`119`	`+ is_dom_comp = HTML_TAG.binary_search(&tag_name.as_str()).is_ok();`
`120`	`120`	`}`
`121`	`121`	`}`
`122`	`122`