fix: version matching

23doors · 23doors · commit f8ad87a99447 · 2021-07-27T16:33:57.000+02:00
diff --git a/pkg/plugins/downloader_vcs.go b/pkg/plugins/downloader_vcs.go
@@ -133,9 +133,11 @@ func (d *VCSDownloader) matchingVersion(ctx context.Context, pi *pluginInfo, che
 		if _, ok := checked[latest.tag]; !ok {
 			checked[latest.tag] = check(latest.tag)
 		}
-	}
 
-	return repo, matching, latest, nil
+		if checked[matching.tag] && checked[latest.tag] {
+			return repo, matching, latest, nil
+		}
+	}
 }
 
 func (d *VCSDownloader) MatchingVersion(ctx context.Context, pi *pluginInfo) (matching, latest *semver.Version, err error) {

Original file line number	Diff line number	Diff line change
`@@ -133,9 +133,11 @@ func (d VCSDownloader) matchingVersion(ctx context.Context, pi pluginInfo, che`
`133`	`133`	`if _, ok := checked[latest.tag]; !ok {`
`134`	`134`	`checked[latest.tag] = check(latest.tag)`
`135`	`135`	`}`
`136`		`- }`
`137`	`136`
`138`		`- return repo, matching, latest, nil`
	`137`	`+ if checked[matching.tag] && checked[latest.tag] {`
	`138`	`+ return repo, matching, latest, nil`
	`139`	`+ }`
	`140`	`+ }`
`139`	`141`	`}`
`140`	`142`
`141`	`143`	`func (d VCSDownloader) MatchingVersion(ctx context.Context, pi pluginInfo) (matching, latest *semver.Version, err error) {`