🐛 Fixes Run all checks on a BranchProtection event - failing tests (#897)

* Run all checks on a BranchProtection event

Signed-off-by: Azeem Shaikh <[email protected]>

* Fixed the failing tests.

Signed-off-by: naveensrinivasan <[email protected]>

Signed-off-by: Azeem Shaikh <[email protected]>
Signed-off-by: naveensrinivasan <[email protected]>
Co-authored-by: Azeem Shaikh <[email protected]>

Author: naveensrinivasan

action.yaml

@@ -53,4 +53,4 @@ branding:
 
 runs:
   using: "docker"
-  image: "docker://gcr.io/openssf/scorecard-action:v2.0.1"
+  image: "docker://gcr.io/openssf/scorecard-action:v2.0.2"

options/options.go

@@ -25,7 +25,6 @@ import (
 	"golang.org/x/net/context"
 
 	"github.com/ossf/scorecard-action/github"
-	"github.com/ossf/scorecard/v4/checks"
 	scopts "github.com/ossf/scorecard/v4/options"
 )
 
@@ -184,11 +183,6 @@ func (o *Options) setScorecardOpts() {
 		o.ScorecardOpts.PolicyFile = defaultScorecardPolicyFile
 	}
 
-	// --checks=
-	if o.GithubEventName == branchProtectionEvent {
-		o.ScorecardOpts.ChecksToRun = []string{checks.CheckBranchProtection}
-	}
-
 	// --show-details
 	o.ScorecardOpts.ShowDetails = true
 

options/options_test.go

@@ -20,7 +20,6 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
-	"github.com/ossf/scorecard/v4/checks"
 	"github.com/ossf/scorecard/v4/options"
 )
 
@@ -137,7 +136,6 @@ func TestNew(t *testing.T) {
 				Commit:      options.DefaultCommit,
 				LogLevel:    options.DefaultLogLevel,
 				Repo:        testRepo,
-				ChecksToRun: []string{checks.CheckBranchProtection},
 				ShowDetails: true,
 			},
 			wantErr: false,