Remove getEventSource() method from Event class ?

[lburgazzoli]

The definition of an Event is:

public interface Event {
    @Deprecated
    String getRelatedCustomResourceUid();

    Predicate<CustomResource> getCustomResourcesSelector();

    EventSource getEventSource();
}

Wonder if getEventSource() could be removed as looking at the code, it is only used for a single test but it is never used internally.

[csviri]

@lburgazzoli since theoretically event source is not necessarily a singleton, this was added there. But might make sense to remove it, since if this info is necessary in some events, could be added just there by the user.

[lburgazzoli]

@csviri yes, I think it would be better.

My reasoning behind this issue is that, the Event source exposes the following methods:

public interface EventSource extends Closeable {
  default void start() {}
  @Override
  default void close() {}
  void setEventHandler(EventHandler eventHandler);
  default void eventSourceDeRegisteredForResource(String customResourceUid) {}
}

And I'm not sure if the event source instance should be exposed by default to the user implementing a controller (through Context.getEvents) as to me it looks like an implementation detail.

[csviri]

@lburgazzoli since the user is registering the event source instance in the init method (and possibly implementing it), it does not seems to be avoidable. Also caching is meant to be happening in event sources so I assume the user will event store it as a loval variable ( in those those cases ) .

[csviri]

Maybe this is a good topic to discuss on weekly meetings also.

[lburgazzoli]

@lburgazzoli since the user is registering the event source instance in the init method (and possibly implementing it), it does not seems to be avoidable.

To add more context, in my specific use case, some of the events sources are registered by a base class (like the timer source) so I'd like to hide them from the user space.