Update golangci-lint and fix complains (#740)

* Update golangci-lint to 1.64.8

Signed-off-by: Jakob Hahn <[email protected]>

* Fix typo in comments

Signed-off-by: Jakob Hahn <[email protected]>

* opensearchtransport: fix musttag linter complain

Signed-off-by: Jakob Hahn <[email protected]>

* fix nolintlint complains

Signed-off-by: Jakob Hahn <[email protected]>

* golangci: remove deprecated linters

Signed-off-by: Jakob Hahn <[email protected]>

* opensearchapi: fix MaxScore type to be a pointer

Signed-off-by: Jakob Hahn <[email protected]>

* golangci: exclude goconst check for all param files

Signed-off-by: Jakob Hahn <[email protected]>

---------

Signed-off-by: Jakob Hahn <[email protected]>

Author: Jakob3xD

.github/workflows/lint.yml

@@ -16,7 +16,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.54.2
+          version: v1.64.8
           args: -v -c .golangci.yml
           only-new-issues: true
 

.golangci.yml

@@ -70,9 +70,7 @@ linters:
     - errchkjson
     - errname
     - errorlint
-    - execinquery
     - exhaustive
-    - exportloopref
     - gci
     - ginkgolinter
     - gocheckcompilerdirectives
@@ -159,7 +157,7 @@ issues:
       path: _test\.go
     - linters:
         - goconst
-      path: opensearchapi\/api_
+      path: -params\.go
     - linters:
         - errcheck
       text: "Error return value of `debugLogger.Logf` is not checked"

CHANGELOG.md

@@ -19,6 +19,8 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Add more SuggestOptions to SearchResp ([#713](https://github.com/opensearch-project/opensearch-go/pull/713))
 - Updates Go version to 1.24 ([#674](https://github.com/opensearch-project/opensearch-go/pull/674))
 - Replace `golang.org/x/exp/slices` usage with built-in `slices` ([#674](https://github.com/opensearch-project/opensearch-go/pull/674))
+- Update golangci-linter to 1.64.8 ([#740](https://github.com/opensearch-project/opensearch-go/pull/740))
+- Change MaxScore to pointer ([#740](https://github.com/opensearch-project/opensearch-go/pull/740))
 
 ### Deprecated
 
@@ -316,7 +318,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Uses `[]string` instead of `string` in `SnapshotDeleteRequest` ([#237](https://github.com/opensearch-project/opensearch-go/pull/237))
 - Updates workflows to reduce CI time, consolidate OpenSearch versions, update compatibility matrix ([#242](https://github.com/opensearch-project/opensearch-go/pull/242))
 - Moves @svencowart to emeritus maintainers ([#270](https://github.com/opensearch-project/opensearch-go/pull/270))
-- Reads, closes and replaces the http Reponse Body ([#300](https://github.com/opensearch-project/opensearch-go/pull/300))
+- Reads, closes and replaces the http Response Body ([#300](https://github.com/opensearch-project/opensearch-go/pull/300))
 
 ### Fixed
 

Makefile

@@ -229,7 +229,7 @@ cluster.clean: ## Remove unused Docker volumes and networks
 	docker system prune --volumes --force
 
 linters:
-	docker run -t --rm -v $$(pwd):/app -v ~/.cache/golangci-lint/v1.54.2:/root/.cache -w /app golangci/golangci-lint:v1.54.2 golangci-lint run --timeout=5m
+	docker run -t --rm -v $$(pwd):/app -v ~/.cache/golangci-lint/v1.64.8:/root/.cache -w /app golangci/golangci-lint:v1.64.8 golangci-lint run --timeout=5m
 
 workflow: ## Run all github workflow commands here sequentially
 

internal/test/helper.go

@@ -38,11 +38,7 @@ func NewClient() (*opensearchapi.Client, error) {
 
 // IsSecure returns true when SECURE_INTEGRATION env is set to true
 func IsSecure() bool {
-	//nolint:gosimple // Getenv returns string not bool, if clause is needed
-	if os.Getenv("SECURE_INTEGRATION") == "true" {
-		return true
-	}
-	return false
+	return os.Getenv("SECURE_INTEGRATION") == "true"
 }
 
 // ClientConfig returns an opensearchapi.Config for secure opensearch

opensearchapi/api_aliases.go

@@ -52,7 +52,7 @@ type AliasesResp struct {
 	response     *opensearch.Response
 }
 
-// Inspect returns the Inspect type containing the raw *opensearch.Reponse
+// Inspect returns the Inspect type containing the raw *opensearch.Response
 func (r AliasesResp) Inspect() Inspect {
 	return Inspect{Response: r.response}
 }

opensearchapi/api_bulk.go

@@ -103,7 +103,7 @@ type BulkRespItem struct {
 	} `json:"error,omitempty"`
 }
 
-// Inspect returns the Inspect type containing the raw *opensearch.Reponse
+// Inspect returns the Inspect type containing the raw *opensearch.Response
 func (r BulkResp) Inspect() Inspect {
 	return Inspect{Response: r.response}
 }

opensearchapi/api_cat-aliases.go

@@ -55,7 +55,7 @@ type CatAliasResp struct {
 	IsWriteIndex  string `json:"is_write_index"`
 }
 
-// Inspect returns the Inspect type containing the raw *opensearch.Reponse
+// Inspect returns the Inspect type containing the raw *opensearch.Response
 func (r CatAliasesResp) Inspect() Inspect {
 	return Inspect{
 		Response: r.response,

opensearchapi/api_cat-allocation.go

@@ -59,7 +59,7 @@ type CatAllocationResp struct {
 	Node        string  `json:"node"`
 }
 
-// Inspect returns the Inspect type containing the raw *opensearch.Reponse
+// Inspect returns the Inspect type containing the raw *opensearch.Response
 func (r CatAllocationsResp) Inspect() Inspect {
 	return Inspect{
 		Response: r.response,

opensearchapi/api_cat-cluster_manager.go

@@ -43,7 +43,7 @@ type CatClusterManagerResp struct {
 	Node string `json:"node"`
 }
 
-// Inspect returns the Inspect type containing the raw *opensearch.Reponse
+// Inspect returns the Inspect type containing the raw *opensearch.Response
 func (r CatClusterManagersResp) Inspect() Inspect {
 	return Inspect{
 		Response: r.response,