Fix recovery last access and routing diff test

Signed-off-by: Max Lepikhin <[email protected]>

Author: maxlepikhin

server/src/main/java/org/opensearch/indices/replication/common/ReplicationTarget.java

@@ -224,6 +224,10 @@ public ActionListener<Void> createOrFinishListener(
             listener = voidListener;
         }
 
+        // Only touch last access when we will actually handle the request (i.e., not a duplicate replay)
+        if (listener != null) {
+            setLastAccessTime();
+        }
         return listener;
     }
 

server/src/test/java/org/opensearch/cluster/routing/remote/RemoteRoutingTableServiceTests.java

@@ -573,13 +573,11 @@ public void testGetAsyncIndexRoutingReadAction() throws Exception {
             compressor,
             Version.CURRENT
         );
-        when(blobContainer.readBlob(indexName)).thenReturn(
-            remoteIndexRoutingTable.indexRoutingTableFormat.serialize(
-                clusterState.getRoutingTable().getIndicesRouting().get(indexName),
-                uploadedFileName,
-                compressor
-            ).streamInput()
-        );
+        when(blobContainer.readBlob(indexName)).thenAnswer(invocation -> remoteIndexRoutingTable.indexRoutingTableFormat.serialize(
+            clusterState.getRoutingTable().getIndicesRouting().get(indexName),
+            uploadedFileName,
+            compressor
+        ).streamInput());
         TestCapturingListener<IndexRoutingTable> listener = new TestCapturingListener<>();
         CountDownLatch latch = new CountDownLatch(1);
 
@@ -611,8 +609,8 @@ public void testGetAsyncIndexRoutingTableDiffReadAction() throws Exception {
             compressor,
             Version.CURRENT
         );
-        when(blobContainer.readBlob(indexName)).thenReturn(
-            remoteRoutingTableDiff.remoteRoutingTableDiffFormat.serialize(diff, uploadedFileName, compressor).streamInput()
+        when(blobContainer.readBlob(indexName)).thenAnswer(
+            invocation -> remoteRoutingTableDiff.remoteRoutingTableDiffFormat.serialize(diff, uploadedFileName, compressor).streamInput()
         );
 
         TestCapturingListener<Diff<RoutingTable>> listener = new TestCapturingListener<>();