Upgrade to 0.29 (#107)

* upgrade to 0.29

* package.json

* fix commands

* fix commands

* fix controller

* update readme

* fix component.rb

* remove test

* remove elections from spec

* remove decidim-elections pack

* fix assign proposal valuators

* fix md5

* fix ReportedMailer spec

* remove similarity_limit

* fix assign_valuators

* fix npm lint

* fix proposal answer template

* fir overriden views

* fix assign/unassign valuators, permissions

* fix tests

* fix upload photos

* add dynamically_attach_file

* add imagemagick

* add imagemagick

* Update CI workflows

* Update CI workflows

* fix show_valuators_name

* fix tests

* add compare step

* change steps

* fix compare step

* fix device_camera_spec

* fix tests

* fix proposals_controller_spec

* refactor

* fix tests

* fix reporting

* fix scss

* specs

* fix specs

* fix specs

---------

Co-authored-by: Ivan Vergés <[email protected]>

Author: antopalidi

.github/workflows/lint.yml

@@ -8,8 +8,10 @@ on:
 
 env:
   CI: "true"
-  RUBY_VERSION: 3.1.1
+  SIMPLECOV: "true"
+  RUBY_VERSION: 3.2.6
   NODE_VERSION: 18.17.1
+  SHAKAPACKER_RUNTIME_COMPILE: "false"
 
 jobs:
   lint-report:
@@ -21,6 +23,11 @@ jobs:
         with:
           fetch-depth: 1
 
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ env.RUBY_VERSION }}
+          bundler-cache: true
+
       - uses: actions/setup-node@master
         with:
           node-version: ${{ env.NODE_VERSION }}
@@ -34,11 +41,6 @@ jobs:
       - run: npm run stylelint
         name: Lint SCSS files
 
-      - uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ env.RUBY_VERSION }}
-          bundler-cache: true
-
       - run: bundle exec rubocop -P
         name: Lint Ruby files
 

.github/workflows/test_integration.yml

@@ -9,20 +9,21 @@ on:
 env:
   CI: "true"
   SIMPLECOV: "true"
-  RUBY_VERSION: 3.1.1
+  RUBY_VERSION: 3.2.6
   NODE_VERSION: 18.17.1
   RAILS_ENV: test
   DATABASE_USERNAME: postgres
   DATABASE_PASSWORD: postgres
   DATABASE_HOST: localhost
+  DISABLE_SPRING: "1"
 jobs:
   build:
     name: Build & Precompile
     runs-on: ubuntu-latest
 
     services:
       postgres:
-        image: postgres:11
+        image: postgres:14
         ports: ["5432:5432"]
         options: >-
           --health-cmd pg_isready
@@ -33,25 +34,27 @@ jobs:
           POSTGRES_PASSWORD: postgres
 
     steps:
-
       - uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
+      - name: Install additional tools
+        run: sudo apt-get update; sudo apt-get -f install wkhtmltopdf imagemagick
+
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ env.RUBY_VERSION }}
           bundler-cache: true
 
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
           node-version: ${{ env.NODE_VERSION }}
           cache: 'npm'
           cache-dependency-path: package-lock.json
 
       - name: Node packages
         run: npm ci
-      
+
       - name: Setup Database
         run: bundle exec rake test_app
 
@@ -98,13 +101,16 @@ jobs:
           POSTGRES_PASSWORD: postgres
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
+      - name: Install additional tools
+        run: sudo apt-get update; sudo apt-get -f install wkhtmltopdf imagemagick
+
       - uses: nanasess/setup-chromedriver@v2
         with:
-          chromedriver-version: 119.0.6045.105
+          chromedriver-version: 126.0.6478.182
 
       - name: List Chrome
         run: apt list --installed | grep chrome
@@ -114,7 +120,7 @@ jobs:
 
       - uses: browser-actions/setup-chrome@v1
         with:
-          chrome-version: 119.0.6045.105
+          chrome-version: 126.0.6478.182
 
       - uses: ruby/setup-ruby@v1
         with:
@@ -128,7 +134,7 @@ jobs:
         with:
           name: workspace
           path: /tmp
-      
+
       - run: ls
       - run: tar -zxf /tmp/testapp-env.tar.gz
       - run: ls

.github/workflows/test_unit.yml

@@ -9,7 +9,7 @@ on:
 env:
   CI: "true"
   SIMPLECOV: "true"
-  RUBY_VERSION: 3.1.1
+  RUBY_VERSION: 3.2.6
   NODE_VERSION: 18.17.1
 
 jobs:
@@ -19,7 +19,7 @@ jobs:
 
     services:
       postgres:
-        image: postgres:11
+        image: postgres:14
         ports: ["5432:5432"]
         options: >-
           --health-cmd pg_isready
@@ -32,15 +32,19 @@ jobs:
       DATABASE_USERNAME: postgres
       DATABASE_PASSWORD: postgres
       DATABASE_HOST: localhost
+      DISABLE_SPRING: "1"
 
     steps:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
+      - name: Install additional tools
+        run: sudo apt-get update; sudo apt-get -f install wkhtmltopdf imagemagick
+
       - uses: nanasess/setup-chromedriver@v2
         with:
-          chromedriver-version: 119.0.6045.105
+          chromedriver-version: 126.0.6478.182
 
       - name: List Chrome
         run: apt list --installed | grep chrome
@@ -50,7 +54,7 @@ jobs:
 
       - uses: browser-actions/setup-chrome@v1
         with:
-          chrome-version: 119.0.6045.105
+          chrome-version: 126.0.6478.182
 
       - uses: ruby/setup-ruby@v1
         with:

.rubocop-disabled.yml

@@ -1,2 +1,22 @@
+
 inherit_from:
-  - https://raw.githubusercontent.com/decidim/decidim/release/0.28-stable/.rubocop.yml
+  - https://raw.githubusercontent.com/decidim/decidim/release/0.29-stable/.rubocop.yml
+
+# Offense count: 8
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+Style/ReturnNilInPredicateMethodDefinition:
+  Enabled: false
+
+# Offense count: 5
+# Configuration parameters: EnforcedStyle, AllowedGems, Include.
+# SupportedStyles: Gemfile, gems.rb, gemspec
+# Include: **/*.gemspec, **/Gemfile, **/gems.rb
+Gemspec/DevelopmentDependencies:
+  Enabled: false
+
+AllCops:
+  Exclude:
+    - "spec/decidim_dummy_app*/**/*"
+    - "development_app/**/*"
+    - "node_modules/**/*"