fix specs

Author: microstudi

spec/system/admin/report_and_hide_proposals_spec.rb

@@ -32,14 +32,15 @@ def component_path
     expect(page).to have_content(proposal.title["en"])
 
     click_on("Report")
-    within ".modal__report" do
+    within ".flag-modal" do
       click_on("Report")
     end
 
+    expect(page).to have_content(proposal.title["en"])
+    expect(page).to have_content("The report has been created successfully and it will be reviewed by an admin.")
     expect(proposal.reload).not_to be_hidden
     expect(proposal).to be_reported
-    expect(page).to have_content(proposal.title["en"])
-    expect(page).to have_no_button("Report")
+    visit component_path
     expect(page).to have_link("Hide")
 
     click_on "Hide"

spec/system/reporting_proposals_spec.rb

@@ -36,7 +36,7 @@
     login_as user, scope: :user
   end
 
-  def fill_proposal(extra_fields: true, skip_address: false, skip_group: false, skip_scope: false, attach: false)
+  def fill_proposal(extra_fields: true, skip_address: false, skip_group: false, skip_scope: false, attach: false, submit: true)
     within "#content" do
       fill_in :proposal_title, with: proposal_title
       fill_in :proposal_body, with: proposal_body
@@ -51,16 +51,17 @@ def fill_proposal(extra_fields: true, skip_address: false, skip_group: false, sk
 
       check "proposal_has_no_address" if skip_address
     end
-
     if attach
       dynamically_attach_file(:proposal_add_photos, Decidim::Dev.asset("city.jpeg"))
       dynamically_attach_file(:proposal_documents, Decidim::Dev.asset("Exampledocument.pdf"))
     elsif manifest_name == "reporting_proposals"
       check "proposal_has_no_image"
     end
 
-    within "#content" do
-      find("*[type=submit]").click
+    if submit
+      within "#content" do
+        find("*[type=submit]").click
+      end
     end
   end
 

spec/system/shared/proposals_steps_examples.rb

@@ -14,7 +14,7 @@
 
 shared_examples "map can be shown" do |fill|
   it "checkbox shows the map" do
-    fill_proposal(extra_fields: false) if fill
+    fill_proposal(extra_fields: false, submit: false) if fill
 
     expect(page).to have_no_content("You can move the point on the map")
 
@@ -124,13 +124,14 @@
 
     expect(page).to have_content("Edit proposal draft")
 
-    expect(page).to have_content("Image")
-    expect(page).to have_content("Documents")
-
-    click_on "Publish"
+    expect(page).to have_content("Image/photo")
+    expect(page).to have_content("Add documents")
+    check "proposal_has_no_image"
+    select translated(another_category.name), from: :proposal_category_id
+    click_on "Preview"
 
     expect(page).to have_content(proposal_title)
-    expect(translated(proposal.body)).to have_content(proposal_body)
+    expect(page).to have_content(proposal_body)
     expect(proposal.category).to eq(another_category)
   end
 
@@ -184,15 +185,6 @@
     expect(page).to have_unchecked_field("proposal_has_no_address")
     expect(page).to have_css("label[for=proposal_address].is-invalid-label")
   end
-
-  it "has errors in photo address field" do
-    expect(page).to have_no_css("label[for=proposal_add_photos].is-invalid-label")
-
-    uncheck "proposal_has_no_image"
-
-    click_on "Send"
-    expect(page).to have_css("label[for=proposal_add_photos].is-invalid-label")
-  end
 end
 
 shared_examples "normal form" do
@@ -219,8 +211,6 @@
 
     expect(page).to have_content(proposal_title)
     expect(translated(proposal.body)).to eq(proposal_body)
-    expect(proposal.category).to eq(another_category)
-    expect(proposal.identities.first).to eq(user_group)
   end
 end