Skip to content

Commit 544b57f

Browse files
Merge pull request #193 from mxsm/dledger-191
[ISSUE #191]Optimize DLedgerLeaderElector.maintainAsCandidate code
2 parents a34df8d + 237f902 commit 544b57f

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/main/java/io/openmessaging/storage/dledger/DLedgerLeaderElector.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -396,6 +396,9 @@ private void maintainAsCandidate() throws Exception {
396396
long term;
397397
long ledgerEndTerm;
398398
long ledgerEndIndex;
399+
if (!memberState.isCandidate()) {
400+
return;
401+
}
399402
synchronized (memberState) {
400403
if (!memberState.isCandidate()) {
401404
return;
@@ -443,9 +446,6 @@ private void maintainAsCandidate() throws Exception {
443446
case ACCEPT:
444447
acceptedNum.incrementAndGet();
445448
break;
446-
case REJECT_ALREADY_VOTED:
447-
case REJECT_TAKING_LEADERSHIP:
448-
break;
449449
case REJECT_ALREADY_HAS_LEADER:
450450
alreadyHasLeader.compareAndSet(false, true);
451451
break;
@@ -462,6 +462,8 @@ private void maintainAsCandidate() throws Exception {
462462
case REJECT_TERM_NOT_READY:
463463
notReadyTermNum.incrementAndGet();
464464
break;
465+
case REJECT_ALREADY_VOTED:
466+
case REJECT_TAKING_LEADERSHIP:
465467
default:
466468
break;
467469

0 commit comments

Comments
 (0)