Fix orphan rule violations in transform logic (WIP)

Co-authored-by: lalitb <[email protected]>

Author: Copilot

opentelemetry-otlp/src/exporter/http/mod.rs

@@ -263,7 +263,7 @@ pub(crate) struct OtlpHttpClient {
     _timeout: Duration,
     #[allow(dead_code)]
     // <allow dead> would be removed once we support set_resource for metrics and traces.
-    resource: opentelemetry_proto::transform::common::tonic::ResourceAttributesWithSchema,
+    resource: crate::transform::common::tonic::ResourceAttributesWithSchema,
 }
 
 impl OtlpHttpClient {

opentelemetry-otlp/src/transform/logs.rs

@@ -156,7 +156,7 @@ pub mod tonic {
                         .schema_url()
                         .map(ToOwned::to_owned)
                         .unwrap_or_default(),
-                    scope: Some((instrumentation, log_record.target().cloned()).into()),
+                    scope: Some(super::common::tonic::instrumentation_scope_from_scope_ref_and_target(instrumentation, log_record.target().cloned())),
                     log_records: vec![log_record.into()],
                 }],
             }

opentelemetry-otlp/src/transform/metrics.rs

@@ -38,40 +38,28 @@ pub mod tonic {
     };
     use crate::transform::common::to_nanos;
 
-    impl From<u64> for exemplar::Value {
-        fn from(value: u64) -> Self {
-            exemplar::Value::AsInt(i64::try_from(value).unwrap_or_default())
-        }
+    pub fn exemplar_value_from_u64(value: u64) -> exemplar::Value {
+        exemplar::Value::AsInt(i64::try_from(value).unwrap_or_default())
     }
 
-    impl From<i64> for exemplar::Value {
-        fn from(value: i64) -> Self {
-            exemplar::Value::AsInt(value)
-        }
+    pub fn exemplar_value_from_i64(value: i64) -> exemplar::Value {
+        exemplar::Value::AsInt(value)
     }
 
-    impl From<f64> for exemplar::Value {
-        fn from(value: f64) -> Self {
-            exemplar::Value::AsDouble(value)
-        }
+    pub fn exemplar_value_from_f64(value: f64) -> exemplar::Value {
+        exemplar::Value::AsDouble(value)
     }
 
-    impl From<u64> for number_data_point::Value {
-        fn from(value: u64) -> Self {
-            number_data_point::Value::AsInt(i64::try_from(value).unwrap_or_default())
-        }
+    pub fn number_data_point_value_from_u64(value: u64) -> number_data_point::Value {
+        number_data_point::Value::AsInt(i64::try_from(value).unwrap_or_default())
     }
 
-    impl From<i64> for number_data_point::Value {
-        fn from(value: i64) -> Self {
-            number_data_point::Value::AsInt(value)
-        }
+    pub fn number_data_point_value_from_i64(value: i64) -> number_data_point::Value {
+        number_data_point::Value::AsInt(value)
     }
 
-    impl From<f64> for number_data_point::Value {
-        fn from(value: f64) -> Self {
-            number_data_point::Value::AsDouble(value)
-        }
+    pub fn number_data_point_value_from_f64(value: f64) -> number_data_point::Value {
+        number_data_point::Value::AsDouble(value)
     }
 
     impl From<(&Key, &Value)> for KeyValue {
@@ -139,7 +127,7 @@ pub mod tonic {
     impl From<&SdkScopeMetrics> for TonicScopeMetrics {
         fn from(sm: &SdkScopeMetrics) -> Self {
             TonicScopeMetrics {
-                scope: Some((sm.scope(), None).into()),
+                scope: Some(super::common::tonic::instrumentation_scope_from_scope_ref_and_target(sm.scope(), None)),
                 metrics: sm.metrics().map(Into::into).collect(),
                 schema_url: sm
                     .scope()

opentelemetry-otlp/src/transform/trace.rs

@@ -106,7 +106,7 @@ pub mod tonic {
                         .schema_url()
                         .map(ToOwned::to_owned)
                         .unwrap_or_default(),
-                    scope: Some((source_span.instrumentation_scope, None).into()),
+                    scope: Some(super::common::tonic::instrumentation_scope_from_scope_and_target(source_span.instrumentation_scope, None)),
                     spans: vec![Span {
                         trace_id: source_span.span_context.trace_id().to_bytes().to_vec(),
                         span_id: source_span.span_context.span_id().to_bytes().to_vec(),
@@ -169,7 +169,7 @@ pub mod tonic {
         let scope_spans = scope_map
             .into_iter()
             .map(|(instrumentation, span_records)| ScopeSpans {
-                scope: Some((instrumentation, None).into()),
+                scope: Some(super::common::tonic::instrumentation_scope_from_scope_ref_and_target(instrumentation, None)),
                 schema_url: resource.schema_url.clone().unwrap_or_default(),
                 spans: span_records
                     .into_iter()