Skip to content

Commit de354db

Browse files
martinkubaMSNev
andauthored
fix: VisibilityState type for typescript >4.6 (#3741)
Co-authored-by: Nev <[email protected]>
1 parent 61aae10 commit de354db

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

experimental/packages/sdk-logs/test/browser/export/BatchLogRecordProcessor.test.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,14 @@ import { InMemoryLogRecordExporter } from './../../../src/export/InMemoryLogReco
2424
const describeDocument =
2525
typeof document === 'object' ? describe : describe.skip;
2626

27+
/**
28+
* VisibilityState has been removed from TypeScript 4.6.0+
29+
*/
30+
type WebVisibilityState = 'visible' | 'hidden';
31+
2732
describeDocument('BatchLogRecordProcessor - web main context', () => {
28-
let visibilityState: VisibilityState = 'visible';
33+
// TODO: change to DocumentVisibilityState when TypeScript is upgraded to 4.6+
34+
let visibilityState: WebVisibilityState = 'visible';
2935
let exporter: LogRecordExporter;
3036
let processor: BatchLogRecordProcessor;
3137
let forceFlushSpy: sinon.SinonStub;

packages/opentelemetry-sdk-trace-base/test/browser/export/BatchSpanProcessor.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ const describeDocument =
3030
typeof document === 'object' ? describe : describe.skip;
3131

3232
describeDocument('BatchSpanProcessor - web main context', () => {
33+
// TODO: change to DocumentVisibilityState when TypeScript is upgraded to 4.6+
3334
let visibilityState: WebVisibilityState = 'visible';
3435
let exporter: SpanExporter;
3536
let processor: BatchSpanProcessor;

0 commit comments

Comments
 (0)