fix: code review fixes

Author: bachgarash

internal/tools/semconvkit/templates/error_type_test.go.tmpl

@@ -33,17 +33,17 @@ func TestErrorType(t *testing.T) {
 		wantStr string
 	}{
 		{
-			name: "BuiltinError",
+			name: "builtin error",
 			err:  builtinErr,
 			want: attribute.String("error.type", "*errors.errorString"),
 		},
 		{
-			name:    "CustomError",
+			name:    "custom error",
 			err:     customErr,
 			wantStr: wantCustomStr,
 		},
 		{
-			name: "NilError",
+			name: "nil error",
 			err:  nilErr,
 			want: ErrorTypeOther,
 		},
@@ -52,13 +52,13 @@ func TestErrorType(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			got := ErrorType(tt.err)
-			if tt.name == "CustomError" {
+			if tt.name == "custom error" {
 				if got.Value.AsString() != tt.wantStr {
-					t.Errorf("Want %s, got %s", tt.wantStr, got.Value.AsString())
+					t.Errorf("ErrorType(%v) = %v, want %v", tt.err, got.Value.AsString(), tt.wantStr)
 				}
 			} else {
 				if got != tt.want {
-					t.Errorf("Want %v, got %v", tt.want, got)
+					t.Errorf("ErrorType(%v) = %v, want %v", tt.err, got, tt.want)
 				}
 			}
 		})

semconv/v1.34.0/error_type_test.go

@@ -33,17 +33,17 @@ func TestErrorType(t *testing.T) {
 		wantStr string
 	}{
 		{
-			name: "BuiltinError",
+			name: "builtin error",
 			err:  builtinErr,
 			want: attribute.String("error.type", "*errors.errorString"),
 		},
 		{
-			name:    "CustomError",
+			name:    "custom error",
 			err:     customErr,
 			want: attribute.String("error.type", wantCustomStr),
 		},
 		{
-			name: "NilError",
+			name: "nil error",
 			err:  nilErr,
 			want: ErrorTypeOther,
 		},
@@ -52,13 +52,13 @@ func TestErrorType(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			got := ErrorType(tt.err)
-			if tt.name == "CustomError" {
+			if tt.name == "custom error" {
 				if got.Value.AsString() != tt.wantStr {
-					t.Errorf("Want %s, got %s", tt.wantStr, got.Value.AsString())
+					t.Errorf("ErrorType(%v) = %v, want %v", tt.err, got.Value.AsString(), tt.wantStr)
 				}
 			} else {
 				if got != tt.want {
-					t.Errorf("Want %v, got %v", tt.want, got)
+					t.Errorf("ErrorType(%v) = %v, want %v", tt.err, got, tt.want)
 				}
 			}
 		})