[OTLP] Address feedback

- Use unused arbitrary.
- Add tests for arbitrary enum values.

Author: martincostello

test/OpenTelemetry.Exporter.OpenTelemetryProtocol.FuzzTests/Generators.cs

@@ -57,7 +57,7 @@ from logAttributesLimit in Gen.Choose(0, 1000).Select(x => (int?)x)
         return gen.ToArbitrary();
     }
 
-    public static Arbitrary<Activity> ActivityArbitrary()
+    public static Arbitrary<Activity> ActivityArbitrary(ActivityStatusCode? status = default)
     {
         var gen = Gen.Sized(size =>
         {
@@ -102,7 +102,7 @@ public static Arbitrary<Activity> ActivityArbitrary()
                 activity.AddLink(new ActivityLink(context, linkTags));
             }
 
-            activity.SetStatus(ActivityStatusCodes.Sample(size, 1).First());
+            activity.SetStatus(status ?? ActivityStatusCodes.Sample(size, 1).First());
 
             return Gen.Constant(activity);
         });
@@ -191,21 +191,21 @@ public static Arbitrary<Batch<Metric>> BatchMetricArbitrary()
     /// <summary>
     /// Generates valid LogRecord instances.
     /// </summary>
-    public static Arbitrary<LogRecord> LogRecordArbitrary()
+    public static Arbitrary<LogRecord> LogRecordArbitrary(LogRecordSeverity? severity = default)
     {
         var gen = Gen.Sized(size =>
         {
             var logRecord = LogRecordSharedPool.Current.Rent();
 
-            logRecord.Severity = LogRecordSeverities.Sample(size, 1).First();
+            logRecord.Severity = severity ?? LogRecordSeverities.Sample(size, 1).First();
             logRecord.Timestamp = DateTime.UtcNow;
 
             // Add attributes
             var count = Math.Min(size, 50);
             var attributes = new List<KeyValuePair<string, object?>>(count);
             for (int i = 0; i < count; i++)
             {
-                attributes.Add(new KeyValuePair<string, object?>($"log.attr.{i}", $"value_{i}"));
+                attributes.Add(new KeyValuePair<string, object?>($"log.attribute.{i}", $"value_{i}"));
             }
 
             if (attributes.Count > 0)

test/OpenTelemetry.Exporter.OpenTelemetryProtocol.FuzzTests/ProtobufOtlpLogSerializerTests.cs

@@ -42,10 +42,6 @@ public Property SerializedDataNeverExceedsBufferSize() => Prop.ForAll(
             {
                 return true;
             }
-            finally
-            {
-                CleanupLogRecords(logRecords);
-            }
         });
 
     [Property(MaxTest = 100)]
@@ -77,10 +73,6 @@ public Property WriteLogsDataReturnsNonNegativePosition() => Prop.ForAll(
             {
                 return true;
             }
-            finally
-            {
-                CleanupLogRecords(logRecords);
-            }
         });
 
     [Property(MaxTest = 50)]
@@ -140,10 +132,6 @@ public Property BufferAutoResizesWhenNeeded() => Prop.ForAll(
             {
                 return true;
             }
-            finally
-            {
-                CleanupLogRecords(logRecords);
-            }
         });
 
     [Property(MaxTest = 50)]
@@ -184,10 +172,6 @@ public Property SerializedOutputCanBeDeserialized() => Prop.ForAll(
             {
                 return true;
             }
-            finally
-            {
-                CleanupLogRecords(logRecords);
-            }
         });
 
     [Property(MaxTest = 50)]
@@ -196,14 +180,12 @@ public Property WriteLogsDataHandlesVariousSeverityLevels() => Prop.ForAll(
         Generators.SdkLimitOptionsArbitrary(),
         (severity, sdkLimits) =>
         {
-            var logRecord = LogRecordSharedPool.Current.Rent();
-            logRecord.Severity = severity;
-            logRecord.Timestamp = DateTime.UtcNow;
+            var logRecord = Generators.LogRecordArbitrary(severity).Generator.Sample(1).ToArray();
 
             try
             {
                 var buffer = new byte[10 * 1024 * 1024];
-                var batch = new Batch<LogRecord>([logRecord], 1);
+                var batch = new Batch<LogRecord>(logRecord, 1);
                 var experimentalOptions = new ExperimentalOptions();
 
                 var writePos = ProtobufOtlpLogSerializer.WriteLogsData(
@@ -220,37 +202,40 @@ public Property WriteLogsDataHandlesVariousSeverityLevels() => Prop.ForAll(
             {
                 return true;
             }
-            finally
-            {
-                LogRecordSharedPool.Current.Return(logRecord);
-            }
         });
 
-    private static LogRecord[] CreateLogRecords(LogRecordSeverity severity)
-    {
-        var logRecords = new List<LogRecord>();
-
-        for (int i = 0; i < 10; i++)
+    [Property(MaxTest = 50)]
+    public Property WriteLogsDataHandlesInvalidSeverities() => Prop.ForAll(
+        Gen.Choose(int.MinValue, int.MaxValue).ToArbitrary(),
+        Generators.SdkLimitOptionsArbitrary(),
+        (severity, sdkLimits) =>
         {
-            var logRecord = LogRecordSharedPool.Current.Rent();
+            var logRecord = Generators.LogRecordArbitrary((LogRecordSeverity)severity).Generator.Sample(1).ToArray();
 
-            logRecord.Attributes = [new($"log.attribute.{i}", $"value_{i}")];
-            logRecord.Severity = severity;
-            logRecord.Timestamp = DateTime.UtcNow;
+            try
+            {
+                var buffer = new byte[10 * 1024 * 1024];
+                var batch = new Batch<LogRecord>(logRecord, 1);
+                var experimentalOptions = new ExperimentalOptions();
 
-            logRecords.Add(logRecord);
-        }
+                var writePos = ProtobufOtlpLogSerializer.WriteLogsData(
+                    ref buffer,
+                    0,
+                    sdkLimits,
+                    experimentalOptions,
+                    null,
+                    batch);
 
-        return [.. logRecords];
-    }
+                return writePos >= 0;
+            }
+            catch (Exception ex) when (IsAllowedException(ex))
+            {
+                return true;
+            }
+        });
 
-    private static void CleanupLogRecords(LogRecord[] logRecords)
-    {
-        foreach (var logRecord in logRecords)
-        {
-            LogRecordSharedPool.Current.Return(logRecord);
-        }
-    }
+    private static LogRecord[] CreateLogRecords(LogRecordSeverity severity)
+        => Generators.LogRecordArbitrary(severity).Generator.ArrayOf().Sample(1, 10).First();
 
     private static bool IsAllowedException(Exception ex)
         => ex is IndexOutOfRangeException or ArgumentException;

test/OpenTelemetry.Exporter.OpenTelemetryProtocol.FuzzTests/ProtobufOtlpTraceSerializerTests.cs

@@ -251,6 +251,41 @@ public Property MultipleSerializationCallsAreConsistent() => Prop.ForAll(
             }
         });
 
+    [Property(MaxTest = 200)]
+    public Property HandlesArbitraryActivityStatusCodes() => Prop.ForAll(
+        Gen.Choose(int.MinValue, int.MaxValue).ToArbitrary(),
+        Generators.SdkLimitOptionsArbitrary(),
+        (statusCode, sdkLimits) =>
+        {
+            var activities = Generators.ActivityArbitrary((ActivityStatusCode)statusCode).Generator.Sample(1).ToArray();
+
+            try
+            {
+                var buffer = new byte[10 * 1024 * 1024]; // 10MB buffer
+                var batch = new Batch<Activity>(activities, activities.Length);
+
+                var writePos = ProtobufOtlpTraceSerializer.WriteTraceData(
+                    ref buffer,
+                    0,
+                    sdkLimits,
+                    null,
+                    batch);
+
+                return writePos >= 0 && writePos <= buffer.Length;
+            }
+            catch (Exception ex) when (IsAllowedException(ex))
+            {
+                return true;
+            }
+            finally
+            {
+                foreach (var activity in activities)
+                {
+                    activity?.Dispose();
+                }
+            }
+        });
+
     private static bool IsAllowedException(Exception ex)
         => ex is IndexOutOfRangeException or ArgumentException;
 }