fix(go-feature-flag): Remove unused variables

[thomaspoignant]

Remove unused variables

[gemini-code-assist]

Summary of Changes

Hello @thomaspoignant, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code hygiene by eliminating an unused field within the Cache struct. This small but important change helps to simplify the codebase, improve readability, and prevent potential confusion for future developers by ensuring that all declared fields serve a purpose.

Highlights

• Code Cleanup: Removed the maxEventInMemory field from the Cache struct in providers/go-feature-flag/pkg/controller/cache.go as it was identified as an unused variable.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes the unused field maxEventInMemory from the Cache struct. This is a good cleanup that improves code maintainability by removing dead code. The change is straightforward and appears to have no side effects.

While reviewing, I noticed a couple of areas for potential future improvement in related files, which are outside the scope of this PR's changes but you might find useful for a follow-up:

• In providers/go-feature-flag/pkg/provider_options.go, the field DataMaxEventInMemory also appears to be unused. You may want to investigate and remove it.
• In providers/go-feature-flag/pkg/controller/cache.go, the various Get... methods (e.g., GetBool, GetString) have very similar implementations. If your project uses Go 1.18 or newer, you could refactor them into a single generic function to reduce code duplication.

Overall, this is a good contribution that improves the codebase.