Skip to content

Commit 4f62d7a

Browse files
koct9ionsi
authored andcommitted
Fix nested --github-output group for progress report nested inside timeline
Do not emit group when progress report is nested in timeline or failure. Unfortunately github logging does not handle nested groups correctly. Commit 606c1cb passed "isVeryVerbose" as to argument "emitGroup", while should pass to "emitGinkgoWriterOutput". So, it break fix added in commit fdc65b1. Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
1 parent 04b5bcb commit 4f62d7a

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

reporters/default_reporter.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ func (r *DefaultReporter) emitTimeline(indent uint, report types.SpecReport, tim
423423
case types.ReportEntry:
424424
r.emitReportEntry(indent, x)
425425
case types.ProgressReport:
426-
r.emitProgressReport(indent, false, isVeryVerbose, x)
426+
r.emitProgressReport(indent, isVeryVerbose, false, x)
427427
case types.SpecEvent:
428428
if isVeryVerbose || !x.IsOnlyVisibleAtVeryVerbose() || r.conf.ShowNodeEvents {
429429
r.emitSpecEvent(indent, x, isVeryVerbose)
@@ -533,6 +533,7 @@ func (r *DefaultReporter) emitProgressReport(indent uint, emitGinkgoWriterOutput
533533
indent -= 1
534534
}
535535

536+
// Emit only top-level groups because github logging cannot handle nested groups correctly.
536537
if r.conf.GithubOutput && emitGroup {
537538
r.emitBlock(r.fi(indent, "::group::Progress Report"))
538539
}

0 commit comments

Comments
 (0)