refactor(connectors)!: move connector routes to /v1alpha/admin/connectors by mattf · Pull Request #5659 · ogx-ai/ogx

mattf · 2026-04-29T15:16:41Z

Connectors are admin controlled resources.

Connector routes previously served at /v1beta/connectors/* are now served at /v1alpha/admin/connectors/* as part of the admin router.

Admin protocol now extends Connectors, so AdminImpl satisfies both protocols. AdminImpl delegates connector methods to the injected ConnectorServiceImpl. The standalone connectors FastAPI router is removed; admin/fastapi_routes.py owns all connector routes.

…tors Connectors are admin controlled resources. Connector routes previously served at /v1beta/connectors/* are now served at /v1alpha/admin/connectors/* as part of the admin router. Admin protocol now extends Connectors, so AdminImpl satisfies both protocols. AdminImpl delegates connector methods to the injected ConnectorServiceImpl. The standalone connectors FastAPI router is removed; admin/fastapi_routes.py owns all connector routes. Signed-off-by: Matthew Farrellee <matt@cs.wisc.edu>

github-actions · 2026-04-29T15:18:40Z

✱ Stainless preview builds

This PR will update the llama-stack-client SDKs with the following commit message.

refactor(connectors)!: move connector routes to /v1alpha/admin/connectors

Edit this comment to update it. It will appear in the SDK's changelogs.

✅ llama-stack-client-go studio · conflict

Your SDK build had at least one new note diagnostic, which is a regression from the base state.

New diagnostics (4 note)

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors`

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors/{connector_id}/tools/{tool_name}`

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors/{connector_id}/tools`

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors/{connector_id}`

✅ llama-stack-client-node studio · conflict

Your SDK build had at least one new note diagnostic, which is a regression from the base state.

New diagnostics (4 note)

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors`

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors/{connector_id}/tools/{tool_name}`

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors/{connector_id}/tools`

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors/{connector_id}`

✅ llama-stack-client-openapi studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️

New diagnostics (4 note)

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors`

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors/{connector_id}/tools/{tool_name}`

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors/{connector_id}/tools`

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors/{connector_id}`

✅ llama-stack-client-python studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️ → build ⏭️ → lint ⏭️ → test ✅

New diagnostics (4 note)

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors`

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors/{connector_id}/tools/{tool_name}`

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors/{connector_id}/tools`

💡 Endpoint/NotConfigured: Skipped endpoint because it's not in your Stainless config: `get /v1alpha/admin/connectors/{connector_id}`

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-04-29 15:38:34 UTC

leseb · 2026-04-29T15:37:35Z

Connectors are admin controlled resources.

Can you expand on that? I'd say so are all our server configs (inference, vector db etc) - what's so unique about Connectors versus other resources?

mattf · 2026-04-29T15:41:46Z

Connectors are admin controlled resources.

Can you expand on that? I'd say so are all our server configs (inference, vector db etc) - what's so unique about Connectors versus other resources?

inference is definitely also an admin controlled resource, we don't let users install new inference providers

vector dbs are user scoped resources, while the available vector providers are admin controlled resources

connectors are a shorthand in Responses that are cross user.

leseb · 2026-04-29T16:24:02Z

i find it strange that users have to go through an /admin endpoint to list available connectors, feels off. to me connectors are no different than tools at this point and they don't serve through /admin?

mattf · 2026-04-29T22:52:59Z

i find it strange that users have to go through an /admin endpoint to list available connectors, feels off. to me connectors are no different than tools at this point and they don't serve through /admin?

the connectors should only be a narrow set of options, defined in the api -

maybe an admin wants to extend this with an internal tool where the user isn't allowed to know the url. for everything else the user knows the url and should just pass it directly.

mattf · 2026-05-07T12:54:26Z

@leseb @franciscojavierarceo @cdoern @raghotham please weigh in

franciscojavierarceo · 2026-05-08T20:43:23Z

I agree with @mattf fwiw

leseb

the only reason for me for this to go behind /v1/admin is that user have no apis to fetch those connector and they are only described in the api

leseb · 2026-05-11T13:57:13Z

@mattf if we do this, then the /v1/tools endpoint should also move to /v1/admin

cdoern

+1 on the logic of why this should be behind admin. lets get this in

# What does this PR do? Moves the `GET /v1/tools` endpoint to `GET /v1/admin/tools`, following the same pattern as ogx-ai#5659 (connectors → admin). Tools are admin-controlled resources configured at the distribution level, not user-scoped — users don't register or unregister tool groups. The rationale is identical to the connectors move. **Pattern followed from ogx-ai#5659:** - `Admin` protocol gains `list_tools` method - `AdminImpl` delegates to the `ToolGroupsRoutingTable` via `self.deps` - Tools `fastapi_routes.py` deleted; route served by the admin router - Admin router restructured with sub-routers to support both `/v1alpha` (existing admin endpoints) and `/v1` (tools) prefixes **BREAKING CHANGE:** `GET /v1/tools` is removed. Use `GET /v1/admin/tools` instead. ## Test Plan 1. Pre-commit checks pass (all except `api-conformance` which is expected for breaking changes — the `refactor!:` commit message signals intentional breakage) 2. Unit tests pass: `uv run pytest tests/unit/core/ --tb=short -q -k "tool or route or admin"` — 77 passed 3. mypy passes with no errors 4. OpenAPI specs regenerated and validated --------- Signed-off-by: Sébastien Han <seb@redhat.com> Signed-off-by: Charlie Doern <cdoern@redhat.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Charlie Doern <cdoern@redhat.com>

mattf added 2 commits April 29, 2026 11:25

revert: change from pre-commit version mismatch

f5c8d3a

revert: change from pre-commit version mismatch

4dfe5b1

mattf marked this pull request as ready for review April 29, 2026 15:41

mattf requested review from bbrowning, cdoern, franciscojavierarceo, leseb and raghotham as code owners April 29, 2026 15:41

leseb approved these changes May 11, 2026

View reviewed changes

cdoern approved these changes May 11, 2026

View reviewed changes

leseb added this pull request to the merge queue May 11, 2026

leseb mentioned this pull request May 11, 2026

refactor(tools)!: move /v1/tools route to /v1/admin/tools #5787

Merged

github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 11, 2026

leseb added this pull request to the merge queue May 11, 2026

Merged via the queue into ogx-ai:main with commit 8e3cb7e May 11, 2026
81 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(connectors)!: move connector routes to /v1alpha/admin/connectors#5659

refactor(connectors)!: move connector routes to /v1alpha/admin/connectors#5659
leseb merged 3 commits into
ogx-ai:mainfrom
mattf:move-connectors-api

mattf commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

leseb commented Apr 29, 2026

Uh oh!

mattf commented Apr 29, 2026

Uh oh!

leseb commented Apr 29, 2026

Uh oh!

mattf commented Apr 29, 2026

Uh oh!

mattf commented May 7, 2026

Uh oh!

franciscojavierarceo commented May 8, 2026

Uh oh!

leseb left a comment

Uh oh!

leseb commented May 11, 2026

Uh oh!

cdoern left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mattf commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✱ Stainless preview builds

Uh oh!

leseb commented Apr 29, 2026

Uh oh!

mattf commented Apr 29, 2026

Uh oh!

leseb commented Apr 29, 2026

Uh oh!

mattf commented Apr 29, 2026

Uh oh!

mattf commented May 7, 2026

Uh oh!

franciscojavierarceo commented May 8, 2026

Uh oh!

leseb left a comment

Choose a reason for hiding this comment

Uh oh!

leseb commented May 11, 2026

Uh oh!

cdoern left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Apr 29, 2026 •

edited

Loading