Skip to content

Commit 0a46cc9

Browse files
fix: add proper type annotations for filters parameter in vector providers
1 parent c74d906 commit 0a46cc9

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/llama_stack/providers/remote/vector_io/pgvector/pgvector.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
from llama_stack.providers.utils.memory.openai_vector_store_mixin import OpenAIVectorStoreMixin
2121
from llama_stack.providers.utils.memory.vector_store import ChunkForDeletion, EmbeddingIndex, VectorStoreWithIndex
2222
from llama_stack.providers.utils.vector_io.filters import Filter
23+
from llama_stack_api.filters import ComparisonFilter, CompoundFilter
2324
from llama_stack.providers.utils.vector_io.vector_utils import (
2425
WeightedInMemoryAggregator,
2526
load_embedded_chunk_with_backward_compat,
@@ -276,7 +277,7 @@ async def query_vector(
276277

277278
return QueryChunksResponse(chunks=chunks, scores=scores)
278279

279-
async def query_keyword(self, query_string: str, k: int, score_threshold: float, filters: Any = None) -> QueryChunksResponse:
280+
async def query_keyword(self, query_string: str, k: int, score_threshold: float, filters: ComparisonFilter | CompoundFilter | None = None) -> QueryChunksResponse:
280281
"""
281282
Performs keyword-based search using PostgreSQL's full-text search with ts_rank scoring.
282283
@@ -324,7 +325,7 @@ async def query_hybrid(
324325
score_threshold: float,
325326
reranker_type: str,
326327
reranker_params: dict[str, Any] | None = None,
327-
filters: Any = None,
328+
filters: ComparisonFilter | CompoundFilter | None = None,
328329
) -> QueryChunksResponse:
329330
"""
330331
Hybrid search combining vector similarity and keyword search using configurable reranking.

src/llama_stack/providers/remote/vector_io/weaviate/weaviate.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
)
2525
from llama_stack.providers.utils.vector_io import load_embedded_chunk_with_backward_compat
2626
from llama_stack.providers.utils.vector_io.filters import Filter as LlamaStackFilter
27+
from llama_stack_api.filters import ComparisonFilter, CompoundFilter
2728
from llama_stack.providers.utils.vector_io.vector_utils import sanitize_collection_name
2829
from llama_stack_api import (
2930
EmbeddedChunk,
@@ -155,7 +156,7 @@ async def delete(self, chunk_ids: list[str] | None = None) -> None:
155156
collection = self.client.collections.get(sanitized_collection_name)
156157
collection.data.delete_many(where=Filter.by_property("id").contains_any(chunk_ids))
157158

158-
async def query_keyword(self, query_string: str, k: int, score_threshold: float, filters: Any = None) -> QueryChunksResponse:
159+
async def query_keyword(self, query_string: str, k: int, score_threshold: float, filters: ComparisonFilter | CompoundFilter | None = None) -> QueryChunksResponse:
159160
"""
160161
Performs BM25-based keyword search using Weaviate's built-in full-text search.
161162
Args:
@@ -211,7 +212,7 @@ async def query_hybrid(
211212
score_threshold: float,
212213
reranker_type: str,
213214
reranker_params: dict[str, Any] | None = None,
214-
filters: Any = None,
215+
filters: ComparisonFilter | CompoundFilter | None = None,
215216
) -> QueryChunksResponse:
216217
"""
217218
Hybrid search combining vector similarity and keyword search using Weaviate's native hybrid search.

0 commit comments

Comments
 (0)