Skip to content

Commit 2a1ce23

Browse files
tombatchelorTom Batchelor
andauthored
fix: add compression var for cross account firehose (#59)
Co-authored-by: Tom Batchelor <[email protected]>
1 parent cd88ff4 commit 2a1ce23

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

examples/cross-account/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ Note that this will create AWS resources - once you are done, run `terraform des
9393
| <a name="input_name"></a> [name](#input\_name) | Name for firehose and matching IAM role | `string` | n/a | yes |
9494
| <a name="input_observe_collection_endpoint"></a> [observe\_collection\_endpoint](#input\_observe\_collection\_endpoint) | Observe Collection Endpoint, e.g https://123456789012.collect.observeinc.com | `string` | n/a | yes |
9595
| <a name="input_observe_token"></a> [observe\_token](#input\_observe\_token) | Observe token | `string` | n/a | yes |
96+
| <a name="input_s3_delivery_compression_format"></a> [s3\_delivery\_compression\_format](#input\_s3\_delivery\_compression\_format) | The compression format. If no value is specified, the default is UNCOMPRESSED. | `string` | `"UNCOMPRESSED"` | no |
9697
| <a name="input_user_arn"></a> [user\_arn](#input\_user\_arn) | ARN for external user granted access to assume role | `string` | n/a | yes |
9798

9899
## Outputs

examples/cross-account/main.tf

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ module "observe_kinesis_firehose" {
1616
name = var.name
1717
cloudwatch_log_group = aws_cloudwatch_log_group.group
1818

19-
http_endpoint_s3_backup_mode = var.http_endpoint_s3_backup_mode
19+
http_endpoint_s3_backup_mode = var.http_endpoint_s3_backup_mode
20+
s3_delivery_compression_format = var.s3_delivery_compression_format
2021
}
2122

2223
resource "aws_iam_role" "this" {

examples/cross-account/variables.tf

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@ variable "http_endpoint_s3_backup_mode" {
2020
default = "FailedDataOnly"
2121
}
2222

23+
variable "s3_delivery_compression_format" {
24+
description = "The compression format. If no value is specified, the default is UNCOMPRESSED."
25+
type = string
26+
nullable = false
27+
default = "UNCOMPRESSED"
28+
}
29+
2330
variable "user_arn" {
2431
type = string
2532
description = "ARN for external user granted access to assume role"

0 commit comments

Comments
 (0)