feat: add aws_account_alias override #206
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpboyd
force-pushed
the
feat/stack-alias
branch
from
06c2b44 to
b387a49
Compare
cpboyd
force-pushed
the
feat/stack-alias
branch
from
b387a49 to
fb6c371
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows manually specifying the
"observeinc.com/accountalias"tag.Fixes #205 (excepting the upstream issue in the AWS provider still exists)
Motivation
We don't have an AWS account alias defined, and would prefer not to have a publicly visible alias.
Limitations
hashicorp/terraform-provider-aws#29324 is still broken
Testing
I've tested manually specifying and disabling the tag.
As we don't have an alias defined, we get an error and cannot verify the existing behavior.