feat: implement custom processor actions for all facets that involve calculating the length of a pcommon.Slice #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-enricogiorio
force-pushed
the
enrico/replaceLenHelm
branch
from
b742f5f to
9c5ad17
Compare
xueweiz
approved these changes
Sep 6, 2024
| }, | ||
| // { | ||
| // name: "noObserveTransformAttributes", | ||
| // inLogs: createResourceLogs( |
There was a problem hiding this comment.
I guess these are not intentional?
Defined as the number of entries in event.data + number of entries in event.binaryData
Add secrets and imagePullSecrets (whose values are the count of the respective fields in the ServiceAccount entity). These cannot be computed in helm due to the Len() function basically not working properly. Fix typos in comments and comment headers' placement
obs-gh-enricogiorio
force-pushed
the
enrico/replaceLenHelm
branch
from
9c5ad17 to
fdcb159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTTL's
Len()doesn't work well with some of the slices obtained by unmarshalling k8s events into their respective API entities. This is becauseLen()doesn't support the type of the inner elements of most of the slices we have to use.As a result, the only way to "calculate" such lengths is via custom code in our events' processor.