internal: add CVE check to release job as blocking #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/vuln-check.yaml
Outdated
|
|
||
| distribution: goreleaser-pro | ||
| version: 2.4.4 | ||
| args: build --snapshot --id=default --skip=validate |
There was a problem hiding this comment.
Does the binary we need get built with --single-target? If so, we can skip other builds to save some cycles.
There was a problem hiding this comment.
ill test that out, should be only a single target required
obs-gh-mattcotter
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
LGTM!
This diff here fixes the go releaser failure fwiw:
https://github.com/observeinc/observe-agent/pull/172/files#diff-7326b55c062b0f46fe9e39aace0a25f4515cf206040fb91a6fd2cae839f5e826
obs-gh-alexlew
force-pushed
the
alew/cve-action
branch
from
ed4c9a0 to
4df2c0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
internal: add CVE check to release job as blocking
Checklist