Skip to content

fix: make full use of nightly build functionality by publishing github releases and not tagging docker images as latest #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

fix: make full use of nightly build functionality by publishing github releases and not tagging docker images as latest #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12b15ac
fix: make full use of nightly build functionality by publishing githu…
obs-gh-mattcotter Feb 26, 2025
f8b7836
skip mis tools install, update goreleaserpro version, try removing pr…
obs-gh-mattcotter Mar 6, 2025
5921f8c
update install scripts to be able to install nightly
obs-gh-mattcotter Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/generate-changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
# either 'goreleaser' (default) or 'goreleaser-pro'
distribution: goreleaser-pro
# 'latest', 'nightly', or a semver
version: 2.4.4
version: 2.7.0
args: changelog
env:
GORELEASER_KEY: ${{ secrets.GORELEASER_KEY }}
6 changes: 1 addition & 5 deletions .github/workflows/release-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,13 @@ jobs:
uses: actions/setup-go@v5
with:
go-version: 1.22.12
- name: Install msitools
run: sudo apt-get install -y wixl
# More assembly might be required: Docker logins, GPG, etc.
# It all depends on your needs.
- name: Install qemu
uses: docker/setup-qemu-action@v3
- name: Run GoReleaser
uses: goreleaser/goreleaser-action@v6
with:
distribution: goreleaser-pro
version: '2.4.4'
version: 2.7.0
args: release --prepare --clean --snapshot --verbose
env:
GORELEASER_KEY: ${{ secrets.GORELEASER_KEY }}
17 changes: 13 additions & 4 deletions .github/workflows/release-nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,23 @@ jobs:
fetch-depth: 0
ref: ${{ github.event.inputs.branch }}

- name: Update the dev-nightly tag
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this part necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github releases are based on git tags. I think we always need a git tag in order to create a GH release. This step updates the dev-nightly tag to the commit from which we are building the release. To keep our releases clean, I figured it would be nice to just have a single nightly tag (I believe this is how the goreleaser repo handles nightly release).

uses: actions/github-script@v7
with:
script: |
github.rest.git.updateRef({
owner: context.repo.owner,
repo: context.repo.repo,
ref: 'tags/dev-nightly',
sha: context.sha,
force: true
})

- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.22.12

- name: Install msitools
run: sudo apt-get install -y wixl

- name: Install qemu
uses: docker/setup-qemu-action@v3

Expand All @@ -55,7 +64,7 @@ jobs:
uses: goreleaser/goreleaser-action@v6
with:
distribution: goreleaser-pro
version: 2.4.4
version: 2.7.0
args: release --clean --skip=validate --verbose --nightly
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ jobs:
with:
go-version: 1.22.12

- name: Install msitools
run: sudo apt-get install -y wixl

- name: Install qemu
uses: docker/setup-qemu-action@v3

Expand All @@ -59,10 +56,9 @@ jobs:
- name: Run GoReleaser
uses: goreleaser/goreleaser-action@v6
with:
# either 'goreleaser' (default) or 'goreleaser-pro'
distribution: goreleaser-pro
# 'latest', 'nightly', or a semver
version: 2.4.4
version: 2.7.0
args: release --clean --skip=validate --verbose
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/tests-integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,14 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.22.12
- name: Install msitools
run: sudo apt-get install -y wixl
go-version: 1.22.12
- name: Install qemu
uses: docker/setup-qemu-action@v3
- name: Run GoReleaser
uses: goreleaser/goreleaser-action@v6
with:
distribution: goreleaser-pro
version: '2.4.4'
version: 2.7.0
args: release --prepare --clean --snapshot --verbose --parallelism 8
env:
GORELEASER_KEY: ${{ secrets.GORELEASER_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vuln-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
uses: goreleaser/goreleaser-action@v6
with:
distribution: goreleaser-pro
version: 2.4.4
version: 2.7.0
args: build --snapshot --id=default --skip=validate --single-target
env:
GORELEASER_KEY: ${{ secrets.GORELEASER_KEY }}
Expand Down
Loading
Loading