Skip to content

fix: make full use of nightly build functionality by publishing github releases and not tagging docker images as latest #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

obs-gh-mattcotter
Copy link
Collaborator

Description

The objective of this change is to create github releases and publish docker images whenever we do a nightly build, but not tag either as latest (and instead use tag dev-nightly). Before this change: no github releases were published, and docker builds were published and tagged latest.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

image_templates:
- *amd64_image_ecr
- *arm64v8_image_ecr

msi:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only advertise installing on windows via zip + powershell script. These msi files are published in our releases currently, but afaik they are never used, so let's save some work and reduce complexity

# Templates: allowed.
mod_timestamp: "{{ .CommitTimestamp }}"

brews:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We install on mac via zip and don't use the homebrew install. This currently isn't published, just built when running release and then ignored.

@obs-gh-mattcotter
Copy link
Collaborator Author

I believe that I can run this workflow before merging, but I will wait until the changes get approved to do so.

@obs-gh-mattcotter obs-gh-mattcotter force-pushed the mc/nightly branch 4 times, most recently from fc7d858 to bf55c89 Compare March 6, 2025 17:47
…b releases and not tagging docker images as latest
@obs-gh-mattcotter
Copy link
Collaborator Author

@obs-gh-mattcotter
Copy link
Collaborator Author

I verified also that docker tags look good:
https://hub.docker.com/r/observeinc/observe-agent/tags

@@ -23,14 +23,23 @@ jobs:
fetch-depth: 0
ref: ${{ github.event.inputs.branch }}

- name: Update the dev-nightly tag
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this part necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github releases are based on git tags. I think we always need a git tag in order to create a GH release. This step updates the dev-nightly tag to the commit from which we are building the release. To keep our releases clean, I figured it would be nice to just have a single nightly tag (I believe this is how the goreleaser repo handles nightly release).

@obs-gh-mattcotter obs-gh-mattcotter merged commit 89d1dca into main Mar 6, 2025
8 checks passed
@obs-gh-mattcotter obs-gh-mattcotter deleted the mc/nightly branch March 6, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants