-
Notifications
You must be signed in to change notification settings - Fork 1
fix: make full use of nightly build functionality by publishing github releases and not tagging docker images as latest #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
image_templates: | ||
- *amd64_image_ecr | ||
- *arm64v8_image_ecr | ||
|
||
msi: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only advertise installing on windows via zip + powershell script. These msi files are published in our releases currently, but afaik they are never used, so let's save some work and reduce complexity
# Templates: allowed. | ||
mod_timestamp: "{{ .CommitTimestamp }}" | ||
|
||
brews: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We install on mac via zip and don't use the homebrew install. This currently isn't published, just built when running release and then ignored.
31ee5b0
to
db315e6
Compare
I believe that I can run this workflow before merging, but I will wait until the changes get approved to do so. |
fc7d858
to
bf55c89
Compare
…b releases and not tagging docker images as latest
bf55c89
to
12b15ac
Compare
@obs-gh-alexlew this seems to be working: https://github.com/observeinc/observe-agent/releases/tag/dev-nightly |
I verified also that docker tags look good: |
@@ -23,14 +23,23 @@ jobs: | |||
fetch-depth: 0 | |||
ref: ${{ github.event.inputs.branch }} | |||
|
|||
- name: Update the dev-nightly tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this part necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github releases are based on git tags. I think we always need a git tag in order to create a GH release. This step updates the dev-nightly
tag to the commit from which we are building the release. To keep our releases clean, I figured it would be nice to just have a single nightly tag (I believe this is how the goreleaser repo handles nightly release).
Description
The objective of this change is to create github releases and publish docker images whenever we do a nightly build, but not tag either as
latest
(and instead use tagdev-nightly
). Before this change: no github releases were published, and docker builds were published and taggedlatest
.Checklist