fix: mac install script: case conversion is a bash 4.0 feature #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-mattcotter
approved these changes
Dec 19, 2024
obs-gh-mattcotter
force-pushed
the
scosol
branch
from
6ed405c to
8e3fc7b
Compare
|
@obs-gh-scottsolmonson I pushed a commit to make the same change to our linux bash script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified for POSIX compliance to use tr
Failing:
scott.solmonson@observe ~ % uname -a Darwin observe-MBP.local 24.2.0 Darwin Kernel Version 24.2.0: Fri Dec 6 19:02:12 PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T6031 arm64scott.solmonson@observe ~ % curl -Ol "https://raw.githubusercontent.com/observeinc/observe-agent/main/scripts/install_mac.sh" && \ bash install_mac.sh --token=ds1CBLIn4zZg4hH6Bf2E:AKC-llFnNUHKUfpeiU3yL_KgU_IryOpF --observe_url=https://109719173327.collect.observeinc.com/ --logs_enabled=true --metrics_enabled=true % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 4516 100 4516 0 0 14145 0 --:--:-- --:--:-- --:--:-- 14156 Downloading latest release from GitHub... Creating system install folders. This may ask for your password... Password: Sorry, try again. Password: Initializing observe-agent.yaml install_mac.sh: line 93: ${LOGS_ENABLED,,}: bad substitution