feat: add new diagnostic check to validate the agent status #126
Conversation
obs-gh-mattcotter
force-pushed
the
OB-32327-more-diagnostics
branch
2 times, most recently
from
38f7215 to
a5e49b3
Compare
obs-gh-mattcotter
force-pushed
the
OB-32327-more-diagnostics
branch
5 times, most recently
from
74dab13 to
28c5dd3
Compare
obs-gh-mattcotter
force-pushed
the
OB-32327-more-diagnostics
branch
4 times, most recently
from
54c311d to
f73323a
Compare
obs-gh-mattcotter
force-pushed
the
OB-32327-more-diagnostics
branch
from
f73323a to
d5337c2
Compare
| print(f"Path to 'dist' directory: {dist_directory}") | ||
|
|
||
| # List files in the directory | ||
| files = os.listdir(dist_directory) |
There was a problem hiding this comment.
@obs-gh-mattcotter are the test_* files that are not test_diagnose just spacing changes? I believe I had used black to format everything but maybe our formatters are different?
There was a problem hiding this comment.
Utils has real changes; I moved some docker helpers there to unify that and add better debug logging. test_config also changed since I split up running the init-config from diagnose command.
But yes, the bulk of the diff there is formatting changes, but they were done with black 🤔
| @u.print_test_decorator | ||
| def run_test_docker(remote_host: u.Host, env_vars: dict) -> None: | ||
| container_id = u.get_docker_container(remote_host) | ||
| exec_prefix = f"sudo docker exec {container_id} ./observe-agent" |
There was a problem hiding this comment.
Awesome! Glad we are adding more testing :)
| @@ -185,9 +171,6 @@ Env vars set to: | |||
| Testing SSH connection to host 54.177.26.178 with timeout 120s | |||
There was a problem hiding this comment.
More spacing/formatting in this file? @obs-gh-mattcotter
There was a problem hiding this comment.
Yes, I just used markdownlint plus a few minor changes;
scripts/test_installation.pywas a typo (or missed name update) forscripts/test_install.py- removed reference to your local
observe-reposfolder - switched images from html to md
Description
OB-32327 add new diagnostic check to validate the agent status, update integration tests to separate config initialization from running the diagnose check
Checklist