refactor: clean up dead testing code #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-enricogiorio
force-pushed
the
enrico/refactorTest
branch
from
26ea2df to
bde51bf
Compare
obs-gh-mattcotter
approved these changes
Oct 31, 2024
Comment on lines
324
to
326
| if !exists { | ||
| kep.logger.Error("no facets map in observe_transform", zap.Error(err)) | ||
| continue |
There was a problem hiding this comment.
This is a functional change and not just a refactor, right? Now if there is an observe_transform attribute with no facets, it will error and ignore rather than defaulting to empty. Is this what we want?
There was a problem hiding this comment.
Actually I made a mistake here, I should have left it as it was. This is dangerous, will revert this bit.
There was a problem hiding this comment.
Because I thought that observe_transform could only be created here (and so we can assume that facets will be here as well).
But actually, this could be created in helm as well.
But the catch here is that if observe_transform is present, then facets is also present inside it
Improve the testing logic to allow each testcase to specify which part of the logRecord the jmespath query should be executed, rather than deciding it once for all testcases of the test function. Remove unused fields + logic that allowed testing w/ custom functions, since we can do everything with jmespath
obs-gh-enricogiorio
force-pushed
the
enrico/refactorTest
branch
from
bde51bf to
4004070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the testing logic to allow each testcase to specify which part of the logRecord the jmespath query should be executed, rather than deciding it once for all testcases of the test function.
Remove unused fields + logic that allowed testing w/ custom functions, since we can do everything with jmespath