feat: add YAML parse check to diagnose command #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func checkConfig() (any, error) { | ||
| if root.CfgFile == "" { |
There was a problem hiding this comment.
where does this get set? would viper.ConfigFileUsed() be a better fit here?
There was a problem hiding this comment.
This gets set by Cobra here:
observe-agent/internal/root/root.go
Line 37 in 9b75d11
But you're right, we have custom handling to find the default file in Viper if that's not set. I updated to viper.ConfigFileUsed(), good catch!
obs-gh-mattcotter
force-pushed
the
OB-37709-yaml-check
branch
from
f9bc65b to
d563fdb
Compare
obs-gh-alexlew
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OB-37709 add a new check to the diagnose command to check if the config file is valid YAML.
Checklist