feat: refactor diagnose command to be more extensible

Author: obs-gh-mattcotter

internal/commands/diagnose/diagnose.go

@@ -22,15 +22,37 @@ var (
 	authcheckTemplateFS embed.FS
 )
 
+var diagnostics = []struct {
+	check      func() (any, error)
+	template   string
+	templateFS embed.FS
+}{
+	{
+		authCheck,
+		authcheckTemplate,
+		authcheckTemplateFS,
+	},
+}
+
 // diagnoseCmd represents the diagnose command
 var diagnoseCmd = &cobra.Command{
 	Use:   "diagnose",
 	Short: "Run diagnostic checks.",
 	Long: `This command runs diagnostic checks for various settings and configurations
 to attempt to identify issues that could cause the agent to function improperly.`,
-	Run: func(cmd *cobra.Command, args []string) {
+	RunE: func(cmd *cobra.Command, args []string) error {
 		fmt.Print("Running diagnosis checks...\n\n")
-		runNetworkCheck()
+		for _, diagnostic := range diagnostics {
+			data, err := diagnostic.check()
+			if err != nil {
+				return err
+			}
+			t := template.Must(template.New(diagnostic.template).ParseFS(diagnostic.templateFS, diagnostic.template))
+			if err := t.ExecuteTemplate(os.Stdout, authcheckTemplate, data); err != nil {
+				return err
+			}
+		}
+		return nil
 	},
 }
 
@@ -48,12 +70,8 @@ func init() {
 	// diagnoseCmd.Flags().BoolP("toggle", "t", false, "Help message for toggle")
 }
 
-func runNetworkCheck() error {
+func authCheck() (any, error) {
 	collector_url := viper.GetString("observe_url")
 	authTestResponse := makeAuthTestRequest(collector_url)
-	t := template.Must(template.New(authcheckTemplate).ParseFS(authcheckTemplateFS, authcheckTemplate))
-	if err := t.ExecuteTemplate(os.Stdout, authcheckTemplate, authTestResponse); err != nil {
-		return err
-	}
-	return nil
+	return authTestResponse, nil
 }

internal/commands/diagnose/networkchecks.go

@@ -47,7 +47,7 @@ func makeTestRequest(URL string, headers map[string]string) NetworkTestResult {
 	if err != nil {
 		return NetworkTestResult{
 			Passed:       false,
-			Error:        "failed to parse response body",
+			Error:        fmt.Sprintf("failed to parse response body: %s", err.Error()),
 			ResponseCode: resp.StatusCode,
 			URL:          URL,
 		}