rename variables for clarity

Author: obs-gh-mattcotter

internal/commands/sendtestdata/postdata.go

@@ -40,9 +40,9 @@ func PostTestData(data any, URL string, headers map[string]string) (string, erro
 	return bodyString, nil
 }
 
-func PostTestDataToObserve(data any, path string, v *viper.Viper) (string, error) {
+func PostDataToObserve(data any, extraPath string, v *viper.Viper) (string, error) {
 	collector_url := v.GetString("observe_url")
-	endpoint := fmt.Sprintf("%s/v1/http%s", strings.TrimRight(collector_url, "/"), path)
+	endpoint := fmt.Sprintf("%s/v1/http%s", strings.TrimRight(collector_url, "/"), extraPath)
 	authToken := fmt.Sprintf("Bearer %s", v.GetString("token"))
 	return PostTestData(data, endpoint, map[string]string{"Authorization": authToken})
 }

internal/commands/sendtestdata/postdata_test.go

@@ -30,7 +30,7 @@ func TestPostTestData(t *testing.T) {
 	assert.Equal(t, expectedResponse, resp)
 }
 
-func TestPostTestDataToObserve(t *testing.T) {
+func TestPostDataToObserve(t *testing.T) {
 	httpmock.Activate()
 	t.Cleanup(httpmock.DeactivateAndReset)
 
@@ -48,7 +48,7 @@ func TestPostTestDataToObserve(t *testing.T) {
 	v.Set("observe_url", "https://123456.collect.observe-eng.com/")
 	v.Set("token", "test-token")
 	testData := map[string]string{"hello": "world"}
-	resp, err := PostTestDataToObserve(testData, "/test", v)
+	resp, err := PostDataToObserve(testData, "/test", v)
 	assert.NoError(t, err)
 	assert.Equal(t, expectedResponse, resp)
 }

internal/commands/sendtestdata/sendtestdata.go

@@ -12,7 +12,7 @@ import (
 	"github.com/spf13/viper"
 )
 
-const TestDataPath = "/observe-agent/test"
+const TestDataExtraPath = "/observe-agent/test"
 
 var defaultTestData = map[string]any{
 	"hello": "world",
@@ -34,7 +34,7 @@ func NewSendTestDataCmd() *cobra.Command {
 			} else {
 				testData = defaultTestData
 			}
-			respBody, err := PostTestDataToObserve(testData, TestDataPath, viper.GetViper())
+			respBody, err := PostDataToObserve(testData, TestDataExtraPath, viper.GetViper())
 			if err != nil {
 				return err
 			}