fix: update terraform to create windows machines

Author: yasar-observe

test_code/AZURE_MACHINES/main.tf

@@ -5,6 +5,11 @@ locals {
   compute_instances = { for key, value in var.AZURE_MACHINE_CONFIGS :
   key => value if contains(var.AZURE_COMPUTE_FILTER, key) || length(var.AZURE_COMPUTE_FILTER) == 0 }
 
+  win_instances = { for key, value in var.AZURE_WIN_MACHINE_CONFIGS :
+  key => value if contains(var.AZURE_COMPUTE_FILTER, key) || length(var.AZURE_COMPUTE_FILTER) == 0 }
+
+  combined_instances = merge(local.compute_instances, local.win_instances)
+
 }
 
 resource "azurerm_resource_group" "linux_host_test" {
@@ -18,7 +23,8 @@ resource "azurerm_linux_virtual_machine" "linux_host_test" {
     azurerm_network_interface_security_group_association.linux_host_test
   ]
   for_each            = local.compute_instances
-  name                = replace(format(var.name_format, "${each.key}-machine"), local.str_f, local.str_r)
+  name                = replace(format(var.name_format, "${each.key}-vm"), local.str_f, local.str_r)
+  computer_name       = each.key
   resource_group_name = azurerm_resource_group.linux_host_test.name
   location            = azurerm_resource_group.linux_host_test.location
   size                = each.value.machine_type
@@ -47,8 +53,33 @@ resource "azurerm_linux_virtual_machine" "linux_host_test" {
   custom_data = filebase64(each.value.user_data)
 }
 
+resource "azurerm_windows_virtual_machine" "linux_host_test" {
+  # https://azapril.dev/2020/05/12/terraform-depends_on/
+  depends_on = [
+    azurerm_network_interface_security_group_association.linux_host_test
+  ]
+  for_each            = local.win_instances
+  name                = replace(format(var.name_format, "${each.key}-machine"), local.str_f, local.str_r)
+  resource_group_name = azurerm_resource_group.linux_host_test.name
+  location            = azurerm_resource_group.linux_host_test.location
+  size                = each.value.machine_type
+  admin_username      = each.value.default_user
+  admin_password      = each.value.default_password
+  network_interface_ids = [
+    azurerm_network_interface.linux_host_test[each.key].id,
+  ]
 
+  os_disk {
+    caching              = "ReadWrite"
+    storage_account_type = "Standard_LRS"
+  }
 
+  source_image_reference {
+    publisher = each.value.source_image_reference.publisher
+    offer     = each.value.source_image_reference.offer
+    sku       = each.value.source_image_reference.sku
+    version   = each.value.source_image_reference.version
+  }
 
-
-
+  custom_data = filebase64(each.value.user_data)
+}

test_code/AZURE_MACHINES/security_group.tf

@@ -1,14 +1,14 @@
 # Create public IPs
 resource "azurerm_public_ip" "linux_host_test" {
-  for_each            = local.compute_instances
+  for_each            = local.combined_instances
   name                = format(var.name_format, "${each.key}_PublicIP")
   location            = azurerm_resource_group.linux_host_test.location
   resource_group_name = azurerm_resource_group.linux_host_test.name
   allocation_method   = "Dynamic"
 }
 
 resource "azurerm_network_interface" "linux_host_test" {
-  for_each            = local.compute_instances
+  for_each            = local.combined_instances
   name                = format(var.name_format, "${each.key}_nic")
   location            = azurerm_resource_group.linux_host_test.location
   resource_group_name = azurerm_resource_group.linux_host_test.name
@@ -42,7 +42,7 @@ resource "azurerm_network_security_group" "linux_host_test" {
 
 # Connect the security group to the network interface
 resource "azurerm_network_interface_security_group_association" "linux_host_test" {
-  for_each                  = local.compute_instances
+  for_each                  = local.combined_instances
   network_interface_id      = azurerm_network_interface.linux_host_test[each.key].id
   network_security_group_id = azurerm_network_security_group.linux_host_test.id
 }

test_code/AZURE_MACHINES/variables.tf

@@ -1,6 +1,6 @@
 # tflint-ignore: terraform_naming_convention
 variable "AZURE_MACHINE_CONFIGS" {
-  description = "variable for what compute instances to create"
+  description = "variable for what linux compute instances to create"
   type        = map(any)
   default = {
     # https://az-vm-image.info/
@@ -87,21 +87,30 @@ variable "AZURE_MACHINE_CONFIGS" {
       sleep = 120
 
     }
-    WIN_10_ENT_21H2 = {
-      recreate     = "changethistorecreate1"
-      machine_type = "Standard_DS1_v2"
-      description  = "Windows 10 Enterprise 21H2"
-      default_user = "test-user"
-      wait         = "120"
-      user_data    = "user_data/windows.ps"
+  }
+}
+
+# tflint-ignore: terraform_naming_convention
+variable "AZURE_WIN_MACHINE_CONFIGS" {
+  description = "variable for what linux compute instances to create"
+  type        = map(any)
+  default = {
+    # az vm image list --output table --all --publisher MicrosoftWindowsDesktop --sku win10-21h2-ent  
+    W10_ENT_21H2 = {
+      recreate         = "changethistorecreate1"
+      machine_type     = "Standard_DS1_v2"
+      description      = "Windows 10 Enterprise 21H2"
+      default_user     = "test-user"
+      default_password = "km$3MWPf&i6r4o@I"
+      wait             = "120"
+      user_data        = "user_data/windows.ps"
       source_image_reference = {
         publisher = "MicrosoftWindowsDesktop"
         offer     = "Windows-10"
         sku       = "win10-21h2-ent-g2"
         version   = "19044.3086.230609"
       }
       sleep = 120
-
     }
   }
 }