Skip to content

Conversation

rossbar
Copy link
Contributor

@rossbar rossbar commented Aug 18, 2020

Update pytest config to ignore entire doc/ directory instead of only doc/conf.py. This prevents an import name collision with doc/scipy-sphinx-theme/conf.py during test collection when the user has inited the scipy-sphinx-theme submodule (and is calling pytest without the module name, i.e. pytest or pytest .).

Alternatively, --ignore=doc/scipy-sphinx-theme/conf.py could be added to setup.cfg to achieve the same effect without ignoring the entire doc directory.

Update pytest config to ignore entire doc/ directory. This prevents
an import name collision in doc/scipy-sphinx-theme/conf.py.
@codecov-commenter
Copy link

Codecov Report

Merging #296 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files           7        7           
  Lines        1263     1263           
=======================================
  Hits         1176     1176           
  Misses         87       87           

@larsoner larsoner merged commit 20d9d98 into numpy:master Aug 19, 2020
@larsoner
Copy link
Collaborator

Thanks @rossbar

@jarrodmillman jarrodmillman added this to the 1.2.0 milestone Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants