Eliminate flaky "in-region" detection #881
chuckwondo
started this conversation in
General
Replies: 2 comments 5 replies
-
|
I considered dropping |
Beta Was this translation helpful? Give feedback.
4 replies
-
|
Discussions around the |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
There are numerous issues surrounding use of S3 vs HTTPS URLs for reading/downloading files via earthaccess, particularly in relation to code that attempts to automatically detect whether or not is is running "in-region" (in us-west-2, specifically). Here are few (and I may have missed some):
access=andin_region=kwargs? #327downloadreturns inconsistent types (Paths orstrs) depending onin_region#595Unfortunately, it seems that in-region detection cannot be done reliably, and causes headaches. Specifically, there are cases where the code fails to detect that is it running in-region, and thus erroneously switches to using HTTPS URLs rather than S3 URLs.
I'm starting this discussion to attempt to consolidate input for what I propose we do:
Of course, we can vary this, but that's the general idea I'm putting forward.
At a high level, I'm thinking that we might do something along the lines of adding a keyword-only parameter to
earthaccess.openandearthaccess.download, which would accept a "handler" for reading/downloading files. The "handler" would default to "S3 w/HTTPS fallback".Beta Was this translation helpful? Give feedback.
All reactions