Merge branch 'main' into zarr-v3

Author: weiji14

.github/workflows/integration-test-review.yml

@@ -32,21 +32,19 @@ jobs:
         uses: actions/github-script@v7
         with:
           script: |
-            const { number, html_url } = (await github.rest.repos.listPullRequestsAssociatedWithCommit({
-              commit_sha: context.sha,
-              owner: "${{ github.event.workflow_run.head_repository.owner.login }}",
-              repo: "${{ github.event.workflow_run.head_repository.name }}",
-            })).data[0] ?? {};
+            const { html_url } = await github.rest.issues.get({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: context.issue.number,
+            });
 
-            if (number) {
-              github.rest.issues.createComment({
-                issue_number: number,
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                body: "User [${{ github.triggering_actor }}](${{ github.event.workflow_run.head_repository.owner.html_url }})"
-                  + " does not have permission to run integration tests. A maintainer must perform a security review of the"
-                  + ` [code changes in this pull request](${html_url}/files) and re-run the`
-                  + " [failed integration tests jobs](${{ github.event.workflow_run.html_url }}),"
-                  + " if the code is deemed safe.",
-              });
-            }
+            github.rest.issues.createComment({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: context.issue.number,
+              body: "User [${{ github.triggering_actor }}](${{ github.event.workflow_run.head_repository.owner.html_url }})"
+                + " does not have permission to run integration tests. A maintainer must perform a security review of the"
+                + ` [code changes in this pull request](${html_url}/files) and re-run the`
+                + " [failed integration tests jobs](${{ github.event.workflow_run.html_url }}),"
+                + " if the code is deemed safe.",
+            });

.github/workflows/integration-test.yml

@@ -120,6 +120,7 @@ jobs:
             --cov=earthaccess \
             --cov-report=term-missing \
             --capture=no \
+            --color=yes \
             --tb=native \
             --log-cli-level=INFO
 

.github/workflows/test-mindeps.yml

@@ -37,7 +37,7 @@ jobs:
         run: uv sync --resolution lowest-direct --extra test
 
       - name: Test
-        run: uv run pytest tests/unit --verbose --cov=earthaccess --cov=tests --cov-report=term-missing --capture=no --tb=native --log-cli-level=INFO
+        run: uv run pytest tests/unit --verbose --cov=earthaccess --cov=tests --cov-report=term-missing --capture=no --color=yes --tb=native --log-cli-level=INFO
 
       - name: Upload coverage
         # Don't upload coverage when using the `act` tool to run the workflow locally

.github/workflows/test.yml

@@ -29,7 +29,7 @@ jobs:
         run: uv run mypy
 
       - name: Test
-        run: uv run pytest tests/unit --verbose --cov=earthaccess --cov-report=term-missing --capture=no --tb=native --log-cli-level=INFO
+        run: uv run pytest tests/unit --verbose --cov=earthaccess --cov-report=term-missing --capture=no --color=yes --tb=native --log-cli-level=INFO
 
       - name: Upload coverage
         # Don't upload coverage when using the `act` tool to run the workflow locally

.pre-commit-config.yaml

@@ -28,14 +28,14 @@ repos:
       - id: trailing-whitespace
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.9.9
+    rev: v0.11.4
     hooks:
       - id: ruff
         args: ["--fix", "--exit-non-zero-on-fix"]
       - id: ruff-format
 
   - repo: https://github.com/astral-sh/uv-pre-commit
-    rev: "0.6.3"
+    rev: "0.6.13"
     hooks:
       # Asserts that the lockfile is valid for pyproject.toml.
       # If it fails, update the lockfile by running:

CHANGELOG.md

@@ -20,6 +20,11 @@ and this project uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html)
   ([#966](https://github.com/nsidc/earthaccess/pull/966))
   ([@weiji14](https://github.com/weiji14))
 
+### Added
+- `get_s3_filesystem` now accepts an `endpoint` argument for specifying a credentials url.
+([#602](https://github.com/nsidc/earthaccess/issues/602))
+([@rwegener2](https://github.com/rwegener2))
+
 
 ## [v0.14.0] - 2025-02-11
 

README.md

@@ -80,6 +80,23 @@ files = earthaccess.download(results, "/tmp/my-download-folder")
 Visit [our quick start guide](https://earthaccess.readthedocs.io/en/latest/quick-start/) for more details.
 
 
+## Help!
+
+We're here for you!
+**Before you open a new issue/discussion/topic, please search to see if anyone else has
+opened a similar one.**
+
+:bug: If you've found a bug or mistake, please use
+[GitHub issues](https://github.com/nsidc/earthaccess/issues).
+
+:bulb: If you'd like to request a feature or ask a question, please use
+[GitHub discussions](https://github.com/nsidc/earthaccess/discussions).
+
+:left_speech_bubble: If you prefer real-time chat, please visit us in our
+[Zulip chat space](https://earthaccess.zulipchat.com)!
+We'd love to see you there! :open_hands:
+
+
 ## Compatibility
 
 The _minimum_ supported Python version is **3.11**.

docs/contributing/index.md

@@ -6,7 +6,8 @@ whether you're finding bugs, adding new features, fixing anything broken, or imp
 When contributing we recommend:
 
 - reading the contributing guide all the way though once before starting
-- searching through issues, discussions, and pull requests to see if your contribution has already been discussed
+- [join us on Zulip chat](https://earthaccess.zulipchat.com) for any questions you may have
+- searching through issues, discussions, pull requests, and Zulip to see if your contribution has already been discussed
   so you don't duplicate work
 
 Then, you can:

earthaccess/api.py

@@ -425,6 +425,7 @@ def get_s3_filesystem(
     daac: Optional[str] = None,
     provider: Optional[str] = None,
     results: Optional[DataGranule] = None,
+    endpoint: Optional[str] = None,
 ) -> s3fs.S3FileSystem:
     """Return an `s3fs.S3FileSystem` for direct access when running within the AWS us-west-2 region.
 
@@ -434,18 +435,29 @@ def get_s3_filesystem(
             If the DAAC is specified, there is no need to use provider.
         results: A list of results from search_data().
             `earthaccess` will use the metadata from CMR to obtain the S3 Endpoint.
+        endpoint: URL of a cloud provider credentials endpoint to be used for obtaining
+            AWS S3 access credentials.
 
     Returns:
         An authenticated s3fs session valid for 1 hour.
     """
     daac = _normalize_location(daac)
     provider = _normalize_location(provider)
-    if results is not None:
+    if results:
         endpoint = results[0].get_s3_credentials_endpoint()
-        if endpoint is not None:
+        if endpoint:
             session = earthaccess.__store__.get_s3_filesystem(endpoint=endpoint)
-            return session
-    session = earthaccess.__store__.get_s3_filesystem(daac=daac, provider=provider)
+        else:
+            raise ValueError("No s3 credentials specified in the given DataGranule")
+    elif endpoint:
+        session = earthaccess.__store__.get_s3_filesystem(endpoint=endpoint)
+    elif daac or provider:
+        session = earthaccess.__store__.get_s3_filesystem(daac=daac, provider=provider)
+    else:
+        raise ValueError(
+            "Invalid set of input arguments given. Please provide either "
+            "a valid result, an endpoint, a daac, or a provider."
+        )
     return session