fix(js): update outDir in runtime tsconfig files to match types export in package.json (#30217)

## Current Behavior

In the TS solution setup, several project generators produce the runtime
tsconfig files (e.g. `tsconfig.lib.json`) with the `outDir` set to
`out-tsc/<project name>`. This causes issues with the inferred
`typecheck` task because the project `package.json` has the `types`
export pointing to `dist/...`, which wouldn't be produced by
`typecheck`.

## Expected Behavior

In the TS solution setup, project generators should produce the runtime
tsconfig files (e.g. `tsconfig.lib.json`) with the `outDir` set to a
path (`dist`) that matches the value in the project `package.json`'s
`types` export.

## Related Issue(s)

Fixes #

Author: leosvelperez

packages/expo/src/generators/application/application.spec.ts

@@ -400,9 +400,9 @@ describe('app', () => {
             "module": "esnext",
             "moduleResolution": "bundler",
             "noUnusedLocals": false,
-            "outDir": "out-tsc/my-app",
+            "outDir": "dist",
             "rootDir": "src",
-            "tsBuildInfoFile": "out-tsc/my-app/tsconfig.app.tsbuildinfo",
+            "tsBuildInfoFile": "dist/tsconfig.app.tsbuildinfo",
             "types": [
               "node",
             ],

packages/expo/src/generators/library/library.spec.ts

@@ -552,9 +552,9 @@ describe('lib', () => {
             "jsx": "react-jsx",
             "module": "esnext",
             "moduleResolution": "bundler",
-            "outDir": "out-tsc/my-lib",
+            "outDir": "dist",
             "rootDir": "src",
-            "tsBuildInfoFile": "out-tsc/my-lib/tsconfig.lib.tsbuildinfo",
+            "tsBuildInfoFile": "dist/tsconfig.lib.tsbuildinfo",
             "types": [
               "node",
             ],

packages/express/src/generators/application/application.spec.ts

@@ -265,9 +265,9 @@ describe('app', () => {
           "compilerOptions": {
             "module": "nodenext",
             "moduleResolution": "nodenext",
-            "outDir": "out-tsc/myapp",
+            "outDir": "dist",
             "rootDir": "src",
-            "tsBuildInfoFile": "out-tsc/myapp/tsconfig.app.tsbuildinfo",
+            "tsBuildInfoFile": "dist/tsconfig.app.tsbuildinfo",
             "types": [
               "node",
               "express",

packages/js/src/generators/library/library.ts

@@ -1031,10 +1031,7 @@ function createProjectTsConfigs(
         .map(([k, v]) => `${JSON.stringify(k)}: ${JSON.stringify(v)}`)
         .join(',\n    '),
       tmpl: '',
-      outDir:
-        options.bundler === 'tsc'
-          ? 'dist'
-          : `out-tsc/${options.projectRoot.split('/').pop()}`,
+      outDir: 'dist',
       emitDeclarationOnly: options.bundler === 'tsc' ? false : true,
     }
   );

packages/js/src/utils/typescript/ts-solution-setup.ts

@@ -140,9 +140,7 @@ export function updateTsconfigFiles(
 
       json.compilerOptions = {
         ...json.compilerOptions,
-        // Make sure d.ts files from typecheck does not conflict with bundlers.
-        // Other tooling like jest write to "out-tsc/jest" to we just default to "out-tsc/<project-name>".
-        outDir: joinPathFragments('out-tsc', projectRoot.split('/').at(-1)),
+        outDir: 'dist',
         rootDir,
         ...compilerOptions,
       };

packages/nest/src/generators/application/application.spec.ts

@@ -281,10 +281,10 @@ describe('application generator', () => {
             "experimentalDecorators": true,
             "module": "nodenext",
             "moduleResolution": "nodenext",
-            "outDir": "out-tsc/myapp",
+            "outDir": "dist",
             "rootDir": "src",
             "target": "es2021",
-            "tsBuildInfoFile": "out-tsc/myapp/tsconfig.app.tsbuildinfo",
+            "tsBuildInfoFile": "dist/tsconfig.app.tsbuildinfo",
             "types": [
               "node",
             ],

packages/next/src/generators/application/application.spec.ts

@@ -981,7 +981,7 @@ describe('app (legacy)', () => {
             "module": "esnext",
             "moduleResolution": "bundler",
             "noEmit": true,
-            "outDir": "out-tsc/myapp",
+            "outDir": "dist",
             "paths": {
               "@/*": [
                 "./src/*",
@@ -995,7 +995,7 @@ describe('app (legacy)', () => {
             "resolveJsonModule": true,
             "rootDir": "src",
             "strict": true,
-            "tsBuildInfoFile": "out-tsc/myapp/tsconfig.tsbuildinfo",
+            "tsBuildInfoFile": "dist/tsconfig.tsbuildinfo",
             "types": [
               "jest",
               "node",

packages/next/src/generators/library/library.spec.ts

@@ -187,9 +187,9 @@ describe('next library', () => {
             "jsx": "react-jsx",
             "module": "esnext",
             "moduleResolution": "bundler",
-            "outDir": "out-tsc/mylib",
+            "outDir": "dist",
             "rootDir": "src",
-            "tsBuildInfoFile": "out-tsc/mylib/tsconfig.lib.tsbuildinfo",
+            "tsBuildInfoFile": "dist/tsconfig.lib.tsbuildinfo",
             "types": [
               "node",
               "@nx/react/typings/cssmodule.d.ts",

packages/node/src/generators/application/application.spec.ts

@@ -667,9 +667,9 @@ describe('app', () => {
           "compilerOptions": {
             "module": "nodenext",
             "moduleResolution": "nodenext",
-            "outDir": "out-tsc/myapp",
+            "outDir": "dist",
             "rootDir": "src",
-            "tsBuildInfoFile": "out-tsc/myapp/tsconfig.app.tsbuildinfo",
+            "tsBuildInfoFile": "dist/tsconfig.app.tsbuildinfo",
             "types": [
               "node",
             ],

packages/nuxt/src/generators/application/application.spec.ts

@@ -286,10 +286,10 @@ describe('app', () => {
             "jsxImportSource": "vue",
             "module": "esnext",
             "moduleResolution": "bundler",
-            "outDir": "out-tsc/myapp",
+            "outDir": "dist",
             "resolveJsonModule": true,
             "rootDir": "src",
-            "tsBuildInfoFile": "out-tsc/myapp/tsconfig.app.tsbuildinfo",
+            "tsBuildInfoFile": "dist/tsconfig.app.tsbuildinfo",
           },
           "exclude": [
             "out-tsc",