Skip to content

[nrf toup] cmake: sign parent image regardless of build strategy #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2019

Conversation

hakonfam
Copy link
Contributor

When a parent image selects MCUboot, it should be signed regardless
of whether or not mcuboot is being built from source.

Signed-off-by: Håkon Øye Amundsen [email protected]

When a parent image selects MCUboot, it should be signed regardless
of whether or not mcuboot is being built from source.

Signed-off-by: Håkon Øye Amundsen <[email protected]>
Copy link

@mbolivar mbolivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just whitespace changes after moving things out of the if block.

@nvlsianpu nvlsianpu merged commit 0a5c298 into nrfconnect:master May 24, 2019
ioannisg pushed a commit to ioannisg/sdk-mcuboot that referenced this pull request Nov 18, 2020
merged by GitHub GUI nrfconnect#38

Signed-off-by: Andrzej Puzdrowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants