Skip to content

Commit 073018b

Browse files
committed
fixup: fewer nested if statements
1 parent 6ef5904 commit 073018b

File tree

1 file changed

+10
-17
lines changed

1 file changed

+10
-17
lines changed

lib/package-envs.js

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,24 @@
1-
// https://github.com/npm/rfcs/pull/183
2-
3-
const envVal = val => {
4-
if (val === null || val === false) {
5-
return ''
6-
}
7-
return String(val)
8-
}
91

102
const packageEnvs = (env, vals, prefix) => {
113
for (const [key, val] of Object.entries(vals)) {
124
if (val === undefined) {
135
continue
14-
} else if (val && typeof val === 'object') {
15-
if (Array.isArray(val)) {
16-
val.forEach((item, index) => {
17-
packageEnvs(env, { [`${key}_${index}`]: item }, `${prefix}`)
18-
})
19-
} else {
20-
packageEnvs(env, val, `${prefix}${key}_`)
21-
}
6+
} else if (val === null || val === false) {
7+
env[`${prefix}${key}`] = ''
8+
} else if (Array.isArray(val)) {
9+
val.forEach((item, index) => {
10+
packageEnvs(env, { [`${key}_${index}`]: item }, `${prefix}`)
11+
})
12+
} else if (typeof val === 'object') {
13+
packageEnvs(env, val, `${prefix}${key}_`)
2214
} else {
23-
env[`${prefix}${key}`] = envVal(val)
15+
env[`${prefix}${key}`] = String(val)
2416
}
2517
}
2618
return env
2719
}
2820

21+
// https://github.com/npm/rfcs/pull/183 defines which fields we put into the environment
2922
module.exports = (env, pkg) => packageEnvs({ ...env }, {
3023
name: pkg.name,
3124
version: pkg.version,

0 commit comments

Comments
 (0)