From 6b15751106beb99234aa4bf39ae05cf40076d42a Mon Sep 17 00:00:00 2001
From: Yash-Singh1 <saiansh2525@gmail.com>
Date: Tue, 24 Nov 2020 14:24:24 -0800
Subject: [PATCH] feat: add npm set-script

Introduces the set-script command. It accepts two arguments,
the script name and the command

ref: https://github.com/npm/rfcs/blob/latest/accepted/0016-set-script-command.md

PR-URL: https://github.com/npm/cli/pull/2237
Credit: @Yash-Singh1
Close: #2237
Reviewed-by: @ruyadorno
---
 docs/content/commands/npm-set-script.md       |  34 ++++
 lib/set-script.js                             |  55 +++++++
 lib/utils/cmd-list.js                         |   1 +
 .../test-lib-utils-cmd-list.js-TAP.test.js    |   1 +
 test/coverage-map.js                          |   3 +-
 test/lib/set-script.js                        | 154 ++++++++++++++++++
 6 files changed, 246 insertions(+), 2 deletions(-)
 create mode 100644 docs/content/commands/npm-set-script.md
 create mode 100644 lib/set-script.js
 create mode 100644 test/lib/set-script.js

diff --git a/docs/content/commands/npm-set-script.md b/docs/content/commands/npm-set-script.md
new file mode 100644
index 0000000000000..7bc8f75d23653
--- /dev/null
+++ b/docs/content/commands/npm-set-script.md
@@ -0,0 +1,34 @@
+---
+title: npm-set-script
+section: 1
+description: Set tasks in the scripts section of package.json
+---
+
+### Synopsis
+An npm command that lets you create a task in the scripts section of the package.json.
+
+```bash
+npm set-script [<script>] [<command>]
+```
+
+
+**Example:**
+
+* `npm set-script start "http-server ."`
+
+```json
+{
+  "name": "my-project",
+  "scripts": {
+    "start": "http-server .",
+    "test": "some existing value"
+  }
+}
+```
+
+### See Also
+
+* [npm run-script](/commands/npm-run-script)
+* [npm install](/commands/npm-install)
+* [npm test](/commands/npm-test)
+* [npm start](/commands/npm-start)
diff --git a/lib/set-script.js b/lib/set-script.js
new file mode 100644
index 0000000000000..4dfc67fbbec2f
--- /dev/null
+++ b/lib/set-script.js
@@ -0,0 +1,55 @@
+'use strict'
+
+const log = require('npmlog')
+const usageUtil = require('./utils/usage.js')
+const { localPrefix } = require('./npm.js')
+const fs = require('fs')
+const usage = usageUtil('set-script', 'npm set-script [<script>] [<command>]')
+const completion = require('./utils/completion/none.js')
+const parseJSON = require('json-parse-even-better-errors')
+const rpj = require('read-package-json-fast')
+
+const cmd = (args, cb) => set(args).then(() => cb()).catch(cb)
+
+const set = async function (args) {
+  if (process.env.npm_lifecycle_event === 'postinstall')
+    throw new Error('Scripts can’t set from the postinstall script')
+
+  // Parse arguments
+  if (args.length !== 2)
+    throw new Error(`Expected 2 arguments: got ${args.length}`)
+
+  // Set the script
+  let manifest
+  let warn = false
+  try {
+    manifest = fs.readFileSync(localPrefix + '/package.json', 'utf-8')
+  } catch (error) {
+    throw new Error('package.json not found')
+  }
+  try {
+    manifest = parseJSON(manifest)
+  } catch (error) {
+    throw new Error(`Invalid package.json: ${error}`)
+  }
+  if (!manifest.scripts)
+    manifest.scripts = {}
+  if (manifest.scripts[args[0]] && manifest.scripts[args[0]] !== args[1])
+    warn = true
+  manifest.scripts[args[0]] = args[1]
+  // format content
+  const packageJsonInfo = await rpj(localPrefix + '/package.json')
+  const {
+    [Symbol.for('indent')]: indent,
+    [Symbol.for('newline')]: newline,
+  } = packageJsonInfo
+  const format = indent === undefined ? '  ' : indent
+  const eol = newline === undefined ? '\n' : newline
+  const content = (JSON.stringify(manifest, null, format) + '\n')
+    .replace(/\n/g, eol)
+  fs.writeFileSync(localPrefix + '/package.json', content)
+  if (warn)
+    log.warn('set-script', `Script "${args[0]}" was overwritten`)
+}
+
+module.exports = Object.assign(cmd, { usage, completion })
diff --git a/lib/utils/cmd-list.js b/lib/utils/cmd-list.js
index 8d8c898d94ae3..8c092e719c05c 100644
--- a/lib/utils/cmd-list.js
+++ b/lib/utils/cmd-list.js
@@ -127,6 +127,7 @@ const cmdList = [
   'start',
   'restart',
   'run-script',
+  'set-script',
   'completion',
   'doctor',
   'exec',
diff --git a/tap-snapshots/test-lib-utils-cmd-list.js-TAP.test.js b/tap-snapshots/test-lib-utils-cmd-list.js-TAP.test.js
index 36066b57639d4..68f0d8328a785 100644
--- a/tap-snapshots/test-lib-utils-cmd-list.js-TAP.test.js
+++ b/tap-snapshots/test-lib-utils-cmd-list.js-TAP.test.js
@@ -162,6 +162,7 @@ Object {
     "start",
     "restart",
     "run-script",
+    "set-script",
     "completion",
     "doctor",
     "exec",
diff --git a/test/coverage-map.js b/test/coverage-map.js
index cb2670129e9c0..6353109da2d56 100644
--- a/test/coverage-map.js
+++ b/test/coverage-map.js
@@ -9,9 +9,8 @@ const coverageMap = (filename) => {
     return glob.sync(`${dir}/**/*.js`)
       .map(f => relative(process.cwd(), f))
   }
-  if (/^test\/(lib|bin)\//.test(filename)) {
+  if (/^test\/(lib|bin)\//.test(filename))
     return filename.replace(/^test\//, '')
-  }
   return []
 }
 
diff --git a/test/lib/set-script.js b/test/lib/set-script.js
new file mode 100644
index 0000000000000..ab25ba968a92c
--- /dev/null
+++ b/test/lib/set-script.js
@@ -0,0 +1,154 @@
+const test = require('tap')
+const requireInject = require('require-inject')
+const setScriptDefault = require('../../lib/set-script.js')
+const parseJSON = require('json-parse-even-better-errors')
+
+test.type(setScriptDefault, 'function', 'command is function')
+test.equal(setScriptDefault.completion, require('../../lib/utils/completion/none.js'), 'empty completion')
+test.equal(setScriptDefault.usage, 'npm set-script [<script>] [<command>]', 'usage matches')
+test.test('fails on invalid arguments', (t) => {
+  const setScript = requireInject('../../lib/set-script.js', {
+    fs: {},
+    npmlog: {},
+  })
+  t.plan(3)
+  setScript(['arg1'], (fail) => t.match(fail, /Expected 2 arguments: got 1/))
+  setScript(['arg1', 'arg2', 'arg3'], (fail) => t.match(fail, /Expected 2 arguments: got 3/))
+  setScript(['arg1', 'arg2', 'arg3', 'arg4'], (fail) => t.match(fail, /Expected 2 arguments: got 4/))
+})
+test.test('fails if run in postinstall script', (t) => {
+  var originalVar = process.env.npm_lifecycle_event
+  process.env.npm_lifecycle_event = 'postinstall'
+  const setScript = requireInject('../../lib/set-script.js', {
+    fs: {},
+    npmlog: {},
+  })
+  t.plan(1)
+  setScript(['arg1', 'arg2'], (fail) => t.equal(fail.toString(), 'Error: Scripts can’t set from the postinstall script'))
+  process.env.npm_lifecycle_event = originalVar
+})
+test.test('fails when package.json not found', (t) => {
+  const setScript = requireInject('../../lib/set-script.js', {
+    '../../lib/npm.js': {
+      localPrefix: 'IDONTEXIST',
+    },
+  })
+  t.plan(1)
+  setScript(['arg1', 'arg2'], (fail) => t.match(fail, /package.json not found/))
+})
+test.test('fails on invalid JSON', (t) => {
+  const setScript = requireInject('../../lib/set-script.js', {
+    fs: {
+      readFileSync: (name, charcode) => {
+        return 'iamnotjson'
+      },
+    },
+  })
+  t.plan(1)
+  setScript(['arg1', 'arg2'], (fail) => t.match(fail, /Invalid package.json: JSONParseError/))
+})
+test.test('creates scripts object', (t) => {
+  var mockFile = ''
+  const setScript = requireInject('../../lib/set-script.js', {
+    fs: {
+      readFileSync: (name, charcode) => {
+        return '{}'
+      },
+      writeFileSync: (location, inner) => {
+        mockFile = inner
+      },
+    },
+    'read-package-json-fast': async function (filename) {
+      return {
+        [Symbol.for('indent')]: '  ',
+        [Symbol.for('newline')]: '\n',
+      }
+    },
+  })
+  t.plan(2)
+  setScript(['arg1', 'arg2'], (error) => {
+    t.equal(error, undefined)
+    t.assert(parseJSON(mockFile), {scripts: {arg1: 'arg2'}})
+  })
+})
+test.test('warns before overwriting', (t) => {
+  var warningListened = ''
+  const setScript = requireInject('../../lib/set-script.js', {
+    fs: {
+      readFileSync: (name, charcode) => {
+        return JSON.stringify({
+          scripts: {
+            arg1: 'blah',
+          },
+        })
+      },
+      writeFileSync: (name, content) => {},
+    },
+    'read-package-json-fast': async function (filename) {
+      return {
+        [Symbol.for('indent')]: '  ',
+        [Symbol.for('newline')]: '\n',
+      }
+    },
+    npmlog: {
+      warn: (prefix, message) => {
+        warningListened = message
+      },
+    },
+  })
+  t.plan(2)
+  setScript(['arg1', 'arg2'], (error) => {
+    t.equal(error, undefined, 'no error')
+    t.equal(warningListened, 'Script "arg1" was overwritten')
+  })
+})
+test.test('provided indentation and eol is used', (t) => {
+  var mockFile = ''
+  const setScript = requireInject('../../lib/set-script.js', {
+    fs: {
+      readFileSync: (name, charcode) => {
+        return '{}'
+      },
+      writeFileSync: (name, content) => {
+        mockFile = content
+      },
+    },
+    'read-package-json-fast': async function (filename) {
+      return {
+        [Symbol.for('indent')]: ' '.repeat(6),
+        [Symbol.for('newline')]: '\r\n',
+      }
+    },
+  })
+  t.plan(3)
+  setScript(['arg1', 'arg2'], (error) => {
+    t.equal(error, undefined)
+    t.equal(mockFile.split('\r\n').length > 1, true)
+    t.equal(mockFile.split('\r\n').every((value) => !value.startsWith(' ') || value.startsWith(' '.repeat(6))), true)
+  })
+})
+test.test('goes to default when undefined indent and eol provided', (t) => {
+  var mockFile = ''
+  const setScript = requireInject('../../lib/set-script.js', {
+    fs: {
+      readFileSync: (name, charcode) => {
+        return '{}'
+      },
+      writeFileSync: (name, content) => {
+        mockFile = content
+      },
+    },
+    'read-package-json-fast': async function (filename) {
+      return {
+        [Symbol.for('indent')]: undefined,
+        [Symbol.for('newline')]: undefined,
+      }
+    },
+  })
+  t.plan(3)
+  setScript(['arg1', 'arg2'], (error) => {
+    t.equal(error, undefined)
+    t.equal(mockFile.split('\n').length > 1, true)
+    t.equal(mockFile.split('\n').every((value) => !value.startsWith(' ') || value.startsWith('  ')), true)
+  })
+})