Skip to content

Commit 9902590

Browse files
committed
add boxen to version-checker output
1 parent 9309821 commit 9902590

File tree

4 files changed

+33
-16
lines changed

4 files changed

+33
-16
lines changed

bin/npm-cli.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,16 @@
9797
})
9898
})
9999

100-
var versionCheckerMessages = []
101-
versionChecker.check()
102-
.stdout.on('data', function (data) {
103-
versionCheckerMessages.push(data.toString())
100+
if (process.stdout.isTTY) {
101+
var versionCheckerMessages = []
102+
versionChecker.check()
103+
.stdout.on('data', function (data) {
104+
versionCheckerMessages.push(data.toString())
105+
})
106+
process.on('exit', () => {
107+
if (versionCheckerMessages.length > 0) {
108+
console.error(versionCheckerMessages.join('\n'))
109+
}
104110
})
105-
process.on('exit', () => {
106-
console.error(versionCheckerMessages.join('\n'))
107-
})
111+
}
108112
})()

lib/utils/version-checker.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
const boxen = require('boxen')
12
const log = require('npmlog')
23
const pacote = require('pacote')
34
const semver = require('semver')
@@ -63,7 +64,7 @@ function generateMessage (oldVersion, latestVersion, diffType, npm) {
6364
}
6465
const changelog = `https://github.com/npm/cli/releases/tag/v${latestVersion}`
6566

66-
return `New ${diffType} version of npm available! ${
67+
let message = `New ${diffType} version of npm available! ${
6768
useColor ? color.red(oldVersion) : oldVersion
6869
} ${useUnicode ? '→' : '->'} ${
6970
useColor ? color.green(latestVersion) : latestVersion
@@ -78,4 +79,13 @@ function generateMessage (oldVersion, latestVersion, diffType, npm) {
7879
? color.green(`npm install -g npm`)
7980
: `npm i -g npm`
8081
} to update!`
82+
83+
const boxenOptions = {
84+
padding: 1,
85+
margin: 1,
86+
align: 'center',
87+
borderColor: 'yellow',
88+
borderStyle: 'round'
89+
}
90+
return boxen(message, boxenOptions)
8191
}

node_modules/boxen/package.json

Lines changed: 9 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
"archy": "~1.0.0",
4242
"bin-links": "^1.1.2",
4343
"bluebird": "~3.5.1",
44+
"boxen": "^1.3.0",
4445
"byte-size": "^4.0.3",
4546
"cacache": "^11.2.0",
4647
"call-limit": "~1.1.0",
@@ -152,6 +153,7 @@
152153
"cacache",
153154
"call-limit",
154155
"bluebird",
156+
"boxen",
155157
"bin-links",
156158
"chownr",
157159
"ci-info",
@@ -247,7 +249,6 @@
247249
"umask",
248250
"unique-filename",
249251
"unpipe",
250-
"update-notifier",
251252
"uuid",
252253
"validate-npm-package-license",
253254
"validate-npm-package-name",

0 commit comments

Comments
 (0)