feat(help): refactor npm help/help-search

Lots of dead code removed thanks to streamlining of logic.
`npm help` `npm <command>` and `npm help-search` are all now separated
concerns, handling their own use cases. `help` calls `help-search` as a
last resort, but `npm <command>` no longer tries to wind its way through
to `help-search` just to get the basic npm usage displayed.

The `did you mean` output has been expanded. It now always suggests top
level commands, scripts, and bins, and suggests them in the way they
should be called.

PR-URL: #2859
Credit: @wraithgar
Close: #2859
Reviewed-by: @ruyadorno

Author: wraithgar

docs/content/commands/npm-dedupe.md

@@ -1,7 +1,7 @@
 ---
 title: npm-dedupe
 section: 1
-description: Reduce duplication
+description: Reduce duplication in the package tree
 ---
 
 ### Synopsis
@@ -10,7 +10,7 @@ description: Reduce duplication
 npm dedupe
 npm ddp
 
-aliases: find-dupes, ddp
+aliases: ddp
 ```
 
 ### Description
@@ -74,6 +74,7 @@ Using `npm find-dupes` will run the command in `--dry-run` mode.
 
 ### See Also
 
+* [npm find-dupes](/cli-commands/find-dupes)
 * [npm ls](/cli-commands/ls)
 * [npm update](/cli-commands/update)
 * [npm install](/cli-commands/install)

docs/content/commands/npm-find-dupes.md

@@ -0,0 +1,24 @@
+---
+title: npm-find-dupes
+section: 1
+description: Find duplication in the package tree
+---
+
+### Synopsis
+
+```bash
+npm find-dupes
+```
+
+### Description
+
+Runs `npm dedupe` in `--dry-run` mode, making npm only output the
+duplications, without actually changing the package tree.
+
+### See Also
+
+* [npm dedupe](/cli-commands/dedupe)
+* [npm ls](/cli-commands/ls)
+* [npm update](/cli-commands/update)
+* [npm install](/cli-commands/install)
+

docs/content/commands/npm-init.md

@@ -1,7 +1,7 @@
 ---
 title: npm-init
 section: 1
-description: create a package.json file
+description: Create a package.json file
 ---
 
 ### Synopsis

lib/access.js

@@ -20,6 +20,10 @@ const subcommands = [
 ]
 
 class Access extends BaseCommand {
+  static get description () {
+    return 'Set access level on published packages'
+  }
+
   static get name () {
     return 'access'
   }

lib/adduser.js

@@ -9,6 +9,10 @@ const authTypes = {
 }
 
 class AddUser extends BaseCommand {
+  static get description () {
+    return 'Add a registry user account'
+  }
+
   static get name () {
     return 'adduser'
   }

lib/audit.js

@@ -5,6 +5,11 @@ const auditError = require('./utils/audit-error.js')
 const BaseCommand = require('./base-command.js')
 
 class Audit extends BaseCommand {
+  /* istanbul ignore next - see test/lib/load-all-commands.js */
+  static get description () {
+    return 'Run a security audit'
+  }
+
   /* istanbul ignore next - see test/lib/load-all-commands.js */
   static get name () {
     return 'audit'

lib/base-command.js

@@ -6,6 +6,14 @@ class BaseCommand {
     this.npm = npm
   }
 
+  get name () {
+    return this.constructor.name
+  }
+
+  get description () {
+    return this.constructor.description
+  }
+
   get usage () {
     let usage = `npm ${this.constructor.name}\n\n`
     if (this.constructor.description)

lib/bin.js

@@ -2,6 +2,10 @@ const envPath = require('./utils/path.js')
 const BaseCommand = require('./base-command.js')
 
 class Bin extends BaseCommand {
+  static get description () {
+    return 'Display npm bin folder'
+  }
+
   static get name () {
     return 'bin'
   }

lib/bugs.js

@@ -5,6 +5,10 @@ const hostedFromMani = require('./utils/hosted-git-info-from-manifest.js')
 const BaseCommand = require('./base-command.js')
 
 class Bugs extends BaseCommand {
+  static get description () {
+    return 'Report bugs for a package in a web browser'
+  }
+
   static get name () {
     return 'bugs'
   }

lib/cache.js

@@ -7,6 +7,10 @@ const rimraf = promisify(require('rimraf'))
 const BaseCommand = require('./base-command.js')
 
 class Cache extends BaseCommand {
+  static get description () {
+    return 'Manipulates packages cache'
+  }
+
   /* istanbul ignore next - see test/lib/load-all-commands.js */
   static get name () {
     return 'cache'