fix: add flatOptions.silent to pass through to pacote

Author: lukekarrys

lib/commands/diff.js

@@ -194,7 +194,6 @@ class Diff extends BaseCommand {
         const packument = await pacote.packument(spec, {
           ...this.npm.flatOptions,
           preferOnline: true,
-          log,
         })
         bSpec = pickManifest(
           packument,

lib/commands/owner.js

@@ -59,7 +59,6 @@ class Owner extends BaseCommand {
   async exec ([action, ...args]) {
     const opts = {
       ...this.npm.flatOptions,
-      log,
     }
     switch (action) {
       case 'ls':

lib/commands/publish.js

@@ -61,7 +61,7 @@ class Publish extends BaseCommand {
       throw new Error('Tag name must not be a valid SemVer range: ' + defaultTag.trim())
     }
 
-    const opts = { ...this.npm.flatOptions, log }
+    const opts = { ...this.npm.flatOptions }
 
     // you can publish name@version, ./foo.tgz, etc.
     // even though the default is the 'file:.' cwd.

lib/commands/view.js

@@ -12,7 +12,7 @@ const relativeDate = require('tiny-relative-date')
 const semver = require('semver')
 const style = require('ansistyles')
 const { inspect, promisify } = require('util')
-const { packument } = require('pacote')
+const pacote = require('pacote')
 
 const readFile = promisify(fs.readFile)
 const readJson = async file => jsonParse(await readFile(file, 'utf8'))
@@ -44,7 +44,7 @@ class View extends BaseCommand {
       preferOnline: true,
     }
     const spec = npa(opts.conf.argv.remain[2])
-    const pckmnt = await packument(spec, config)
+    const pckmnt = await pacote.packument(spec, config)
     const defaultTag = this.npm.config.get('tag')
     const dv = pckmnt.versions[pckmnt['dist-tags'][defaultTag]]
     pckmnt.versions = Object.keys(pckmnt.versions).sort(semver.compareLoose)
@@ -198,7 +198,7 @@ class View extends BaseCommand {
       version = spec.rawSpec
     }
 
-    const pckmnt = await packument(spec, opts)
+    const pckmnt = await pacote.packument(spec, opts)
 
     if (pckmnt['dist-tags'] && pckmnt['dist-tags'][version]) {
       version = pckmnt['dist-tags'][version]

lib/npm.js

@@ -285,6 +285,9 @@ class Npm extends EventEmitter {
     const { flat } = this.config
     if (this.command) {
       flat.npmCommand = this.command
+      // XXX: ensure we pass silent everywhere that flatOptions
+      // is being based. this will get removed in a future refactor
+      flat.silent = this.config.get('loglevel') === 'silent'
     }
     return flat
   }

workspaces/libnpmpack/lib/index.js

@@ -14,9 +14,8 @@ async function pack (spec = 'file:.', opts = {}) {
 
   const manifest = await pacote.manifest(spec, opts)
 
-  // Default to true if no log options passed, set to false if we're in silent
-  // mode
-  const banner = !opts.log || (opts.log.level !== 'silent')
+  // set to false if we're in silent mode
+  const banner = !opts.silent
 
   if (spec.type === 'directory') {
     // prepack