Skip to content

Commit 29a3009

Browse files
lukekarryswraithgar
authored andcommitted
chore: move doc deps to dev
This moves all the dependencies of the `docs/` workspace to dev deps. I had originally moved them out of devDeps as part of #5309, but this seems to go against the grain of other tooling. We would have to special case both `audit` and `licensee` to run on a custom subset of our dependency tree. Maybe one day when all tools can be piped the output of an `npm query` this will be possible. It would be nice if we could only audit dependencies that are bundled as part of the CLI. But for now it's easier to move these to devDeps and then reinstall only the docs workspace after pruning during the publish step.
1 parent edbbc3a commit 29a3009

File tree

6 files changed

+153
-170
lines changed

6 files changed

+153
-170
lines changed

.github/workflows/audit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@ jobs:
3131
- name: Reset Deps
3232
run: node . run resetdeps -- --package-lock
3333
- name: Run Audit
34-
run: node . audit -iwr -w workspaces
34+
run: node . audit

DEPENDENCIES.md

Lines changed: 2 additions & 126 deletions
Original file line numberDiff line numberDiff line change
@@ -243,8 +243,6 @@ graph LR;
243243
## all dependencies
244244
```mermaid
245245
graph LR;
246-
acorn-globals-->acorn-walk;
247-
acorn-globals-->acorn;
248246
agent-base-->debug;
249247
agentkeepalive-->debug;
250248
agentkeepalive-->depd;
@@ -254,18 +252,11 @@ graph LR;
254252
ansi-styles-->color-convert;
255253
are-we-there-yet-->delegates;
256254
are-we-there-yet-->readable-stream;
257-
argparse-->sprintf-js;
258255
bin-links-->cmd-shim;
259256
bin-links-->npm-normalize-package-bin;
260257
bin-links-->read-cmd-shim;
261258
bin-links-->write-file-atomic;
262-
bindings-->file-uri-to-path;
263-
bl-->buffer;
264-
bl-->inherits;
265-
bl-->readable-stream;
266259
brace-expansion-->balanced-match;
267-
buffer-->base64-js;
268-
buffer-->ieee754;
269260
builtins-->semver;
270261
cacache-->chownr;
271262
cacache-->fs-minipass;
@@ -292,39 +283,19 @@ graph LR;
292283
cli-columns-->strip-ansi;
293284
cli-table3-->colors-colors["@colors/colors"];
294285
cli-table3-->string-width;
295-
cmark-gfm-->bindings;
296-
cmark-gfm-->node-addon-api;
297-
cmark-gfm-->prebuild-install;
298286
color-convert-->color-name;
299287
columnify-->strip-ansi;
300288
columnify-->wcwidth;
301-
combined-stream-->delayed-stream;
302-
cssstyle-->cssom;
303-
data-urls-->abab;
304-
data-urls-->whatwg-mimetype;
305-
data-urls-->whatwg-url;
306289
debug-->ms;
307-
decompress-response-->mimic-response;
308290
defaults-->clone;
309291
dezalgo-->asap;
310292
dezalgo-->wrappy;
311-
domexception-->webidl-conversions;
312293
encoding-->iconv-lite;
313-
end-of-stream-->once;
314-
escodegen-->esprima;
315-
escodegen-->estraverse;
316-
escodegen-->esutils;
317-
escodegen-->optionator;
318-
escodegen-->source-map;
319-
form-data-->asynckit;
320-
form-data-->combined-stream;
321-
form-data-->mime-types;
322-
front-matter-->js-yaml;
323294
fs-minipass-->minipass;
324295
gauge-->aproba;
296+
gauge-->color-support;
325297
gauge-->console-control-strings;
326298
gauge-->has-unicode;
327-
gauge-->object-assign;
328299
gauge-->signal-exit;
329300
gauge-->string-width;
330301
gauge-->strip-ansi;
@@ -337,7 +308,6 @@ graph LR;
337308
glob-->path-is-absolute;
338309
has-->function-bind;
339310
hosted-git-info-->lru-cache;
340-
html-encoding-sniffer-->whatwg-encoding;
341311
http-proxy-agent-->agent-base;
342312
http-proxy-agent-->debug;
343313
http-proxy-agent-->tootallnate-once["@tootallnate/once"];
@@ -357,38 +327,6 @@ graph LR;
357327
init-package-json-->validate-npm-package-name;
358328
is-cidr-->cidr-regex;
359329
is-core-module-->has;
360-
is-fullwidth-code-point-->number-is-nan;
361-
js-yaml-->argparse;
362-
js-yaml-->esprima;
363-
jsdom-->abab;
364-
jsdom-->acorn-globals;
365-
jsdom-->acorn;
366-
jsdom-->canvas;
367-
jsdom-->cssom;
368-
jsdom-->cssstyle;
369-
jsdom-->data-urls;
370-
jsdom-->decimal.js;
371-
jsdom-->domexception;
372-
jsdom-->escodegen;
373-
jsdom-->form-data;
374-
jsdom-->html-encoding-sniffer;
375-
jsdom-->http-proxy-agent;
376-
jsdom-->https-proxy-agent;
377-
jsdom-->is-potential-custom-element-name;
378-
jsdom-->nwsapi;
379-
jsdom-->parse5;
380-
jsdom-->saxes;
381-
jsdom-->symbol-tree;
382-
jsdom-->tough-cookie;
383-
jsdom-->w3c-xmlserializer;
384-
jsdom-->webidl-conversions;
385-
jsdom-->whatwg-encoding;
386-
jsdom-->whatwg-mimetype;
387-
jsdom-->whatwg-url;
388-
jsdom-->ws;
389-
jsdom-->xml-name-validator;
390-
levn-->prelude-ls;
391-
levn-->type-check;
392330
libnpmaccess-->nock;
393331
libnpmaccess-->npm-package-arg;
394332
libnpmaccess-->npm-registry-fetch;
@@ -499,8 +437,6 @@ graph LR;
499437
make-fetch-happen-->promise-retry;
500438
make-fetch-happen-->socks-proxy-agent;
501439
make-fetch-happen-->ssri;
502-
marked-man-->marked;
503-
mime-types-->mime-db;
504440
minimatch-->brace-expansion;
505441
minipass-->yallist;
506442
minipass-collect-->minipass;
@@ -515,7 +451,6 @@ graph LR;
515451
minipass-sized-->minipass;
516452
minizlib-->minipass;
517453
minizlib-->yallist;
518-
node-abi-->semver;
519454
node-gyp-->env-paths;
520455
node-gyp-->glob;
521456
node-gyp-->graceful-fs;
@@ -729,12 +664,6 @@ graph LR;
729664
npmlog-->gauge;
730665
npmlog-->set-blocking;
731666
once-->wrappy;
732-
optionator-->deep-is;
733-
optionator-->fast-levenshtein;
734-
optionator-->levn;
735-
optionator-->prelude-ls;
736-
optionator-->type-check;
737-
optionator-->word-wrap;
738667
p-map-->aggregate-error;
739668
pacote-->cacache;
740669
pacote-->fs-minipass;
@@ -756,55 +685,27 @@ graph LR;
756685
parse-conflict-json-->json-parse-even-better-errors;
757686
parse-conflict-json-->just-diff-apply;
758687
parse-conflict-json-->just-diff;
759-
parse5-->entities;
760688
postcss-selector-parser-->cssesc;
761689
postcss-selector-parser-->util-deprecate;
762-
prebuild-install-->detect-libc;
763-
prebuild-install-->expand-template;
764-
prebuild-install-->github-from-package;
765-
prebuild-install-->minimist;
766-
prebuild-install-->mkdirp-classic;
767-
prebuild-install-->napi-build-utils;
768-
prebuild-install-->node-abi;
769-
prebuild-install-->npmlog;
770-
prebuild-install-->pump;
771-
prebuild-install-->rc;
772-
prebuild-install-->simple-get;
773-
prebuild-install-->tar-fs;
774-
prebuild-install-->tunnel-agent;
775690
promise-retry-->err-code;
776691
promise-retry-->retry;
777692
promzard-->read;
778-
pump-->end-of-stream;
779-
pump-->once;
780-
rc-->deep-extend;
781-
rc-->ini;
782-
rc-->minimist;
783-
rc-->strip-json-comments;
784693
read-->mute-stream;
785694
read-package-json-->glob;
786695
read-package-json-->json-parse-even-better-errors;
787696
read-package-json-->normalize-package-data;
788697
read-package-json-->npm-normalize-package-bin;
789698
read-package-json-fast-->json-parse-even-better-errors;
790699
read-package-json-fast-->npm-normalize-package-bin;
791-
readable-stream-->core-util-is;
792700
readable-stream-->inherits;
793-
readable-stream-->isarray;
794-
readable-stream-->process-nextick-args;
795-
readable-stream-->safe-buffer;
796701
readable-stream-->string_decoder;
797702
readable-stream-->util-deprecate;
798703
readdir-scoped-modules-->debuglog;
799704
readdir-scoped-modules-->dezalgo;
800705
readdir-scoped-modules-->graceful-fs;
801706
readdir-scoped-modules-->once;
802707
rimraf-->glob;
803-
saxes-->xmlchars;
804708
semver-->lru-cache;
805-
simple-get-->decompress-response;
806-
simple-get-->once;
807-
simple-get-->simple-concat;
808709
smoke-tests-->minify-registry-metadata;
809710
smoke-tests-->npmcli-eslint-config["@npmcli/eslint-config"];
810711
smoke-tests-->npmcli-promise-spawn["@npmcli/promise-spawn"];
@@ -822,7 +723,6 @@ graph LR;
822723
spdx-expression-parse-->spdx-exceptions;
823724
spdx-expression-parse-->spdx-license-ids;
824725
ssri-->minipass;
825-
string-width-->code-point-at;
826726
string-width-->emoji-regex;
827727
string-width-->is-fullwidth-code-point;
828728
string-width-->strip-ansi;
@@ -835,40 +735,16 @@ graph LR;
835735
tar-->minizlib;
836736
tar-->mkdirp;
837737
tar-->yallist;
838-
tar-fs-->chownr;
839-
tar-fs-->mkdirp-classic;
840-
tar-fs-->pump;
841-
tar-fs-->tar-stream;
842-
tar-stream-->bl;
843-
tar-stream-->end-of-stream;
844-
tar-stream-->fs-constants;
845-
tar-stream-->inherits;
846-
tar-stream-->readable-stream;
847-
tough-cookie-->psl;
848-
tough-cookie-->punycode;
849-
tough-cookie-->universalify;
850-
tough-cookie-->url-parse;
851-
tr46-->punycode;
852-
tunnel-agent-->safe-buffer;
853-
type-check-->prelude-ls;
854738
unique-filename-->unique-slug;
855739
unique-slug-->imurmurhash;
856-
url-parse-->querystringify;
857-
url-parse-->requires-port;
858740
validate-npm-package-license-->spdx-correct;
859741
validate-npm-package-license-->spdx-expression-parse;
860742
validate-npm-package-name-->builtins;
861-
w3c-xmlserializer-->xml-name-validator;
862743
wcwidth-->defaults;
863-
whatwg-encoding-->iconv-lite;
864-
whatwg-url-->tr46;
865-
whatwg-url-->webidl-conversions;
866744
which-->isexe;
867745
wide-align-->string-width;
868746
write-file-atomic-->imurmurhash;
869747
write-file-atomic-->signal-exit;
870-
ws-->bufferutil;
871-
ws-->utf-8-validate;
872748
```
873749

874750
## npm dependency heirarchy
@@ -887,4 +763,4 @@ packages higher up the chain.
887763
- @npmcli/git, make-fetch-happen, @npmcli/config, init-package-json
888764
- @npmcli/installed-package-contents, @npmcli/map-workspaces, cacache, npm-pick-manifest, @npmcli/run-script, read-package-json, readdir-scoped-modules, promzard
889765
- @npmcli/docs, npm-bundled, read-package-json-fast, @npmcli/fs, unique-filename, npm-install-checks, npm-package-arg, npm-packlist, normalize-package-data, @npmcli/package-json, bin-links, nopt, npmlog, parse-conflict-json, dezalgo, read
890-
- ignore-walk, @npmcli/eslint-config, @npmcli/template-oss, npm-normalize-package-bin, @npmcli/name-from-folder, json-parse-even-better-errors, semver, @npmcli/move-file, fs-minipass, ssri, unique-slug, @npmcli/promise-spawn, hosted-git-info, proc-log, validate-npm-package-name, @npmcli/node-gyp, minipass-fetch, @npmcli/query, cmd-shim, read-cmd-shim, write-file-atomic, abbrev, are-we-there-yet, gauge, wrappy, treeverse, minify-registry-metadata, @npmcli/disparity-colors, @npmcli/ci-detect, mute-stream, ini, npm-audit-report, npm-user-validate
766+
- @npmcli/eslint-config, @npmcli/template-oss, ignore-walk, npm-normalize-package-bin, @npmcli/name-from-folder, json-parse-even-better-errors, semver, @npmcli/move-file, fs-minipass, ssri, unique-slug, @npmcli/promise-spawn, hosted-git-info, proc-log, validate-npm-package-name, @npmcli/node-gyp, minipass-fetch, @npmcli/query, cmd-shim, read-cmd-shim, write-file-atomic, abbrev, are-we-there-yet, gauge, wrappy, treeverse, minify-registry-metadata, @npmcli/disparity-colors, @npmcli/ci-detect, mute-stream, ini, npm-audit-report, npm-user-validate

docs/package.json

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,19 @@
2222
"url": "https://github.com/npm/cli.git",
2323
"directory": "docs"
2424
},
25-
"dependencies": {
25+
"devDependencies": {
2626
"@isaacs/string-locale-compare": "^1.1.0",
27+
"@npmcli/eslint-config": "^4.0.0",
28+
"@npmcli/template-oss": "4.7.1",
2729
"cmark-gfm": "^0.9.0",
2830
"front-matter": "^4.0.2",
2931
"ignore-walk": "^6.0.0",
3032
"jsdom": "^20.0.1",
3133
"marked-man": "^0.7.0",
3234
"mkdirp": "^1.0.4",
35+
"tap": "^16.0.1",
3336
"yaml": "^2.1.3"
3437
},
35-
"devDependencies": {
36-
"@npmcli/eslint-config": "^4.0.0",
37-
"@npmcli/template-oss": "4.7.1",
38-
"tap": "^16.0.1"
39-
},
4038
"author": "GitHub Inc.",
4139
"license": "ISC",
4240
"files": [

0 commit comments

Comments
 (0)