fix: path resolution for global linking filepaths

related to: npm/cli#1786

Co-authored-by: isaacs <[email protected]>

Author: ruyadorno

lib/add-rm-pkg-deps.js

@@ -55,7 +55,7 @@ const addSingle = ({pkg, spec, saveBundle, saveType, path}) => {
   pkg[type] = pkg[type] || {}
   if (rawSpec !== '' || pkg[type][name] === undefined) {
     // if we're in global mode, file specs are based on cwd, not arb path
-    pkg[type][name] = specType === 'file' ? `file:${relpath(path, fetchSpec)}`
+    pkg[type][name] = specType === 'file' || specType === 'directory' ? `file:${relpath(path, fetchSpec)}`
       : (rawSpec || '*')
   }
 

test/arborist/build-ideal-tree.js

@@ -1348,6 +1348,28 @@ t.test('resolve files from cwd in global mode, Arb path in local mode', t => {
   })
 })
 
+t.only('resolve links in global mode', t => {
+  const cwd = process.cwd()
+  t.teardown(() => process.chdir(cwd))
+  const path = t.testdir({
+    global: {}
+  })
+  const fixturedir = resolve(fixtures, 'root-bundler')
+  process.chdir(fixturedir)
+  const arb = new Arborist({
+    global: true,
+    path: resolve(path, 'global'),
+    ...OPT,
+  })
+  return arb.buildIdealTree({
+    add: ['file:../sax'],
+    global: true,
+  }).then(tree => {
+    const resolved = 'file:../../../../fixtures/sax'
+    t.equal(tree.children.get('sax').resolved, resolved)
+  })
+})
+
 t.test('dont get confused if root matches duped metadep', async t => {
   const path = resolve(fixtures, 'test-root-matches-metadep')
   const arb = new Arborist({ path, ...OPT })