[various] Speed up build-examples (flutter#3849)

reidbaker · nploi · commit ee83c5852c4e · 2023-07-16T20:56:36.000+07:00
flutter/flutter#125707 - Create pluginTools config for every example that shrunk material icons and had an android config Likely some build caching but before/after If someone knows how to clean the cache or force a rebuild I will give more accurate after numbers. Command `time dart run ./script/tool/bin/flutter_plugin_tools.dart build-examples --apk` Secondary validation from @stuartmorgan who discovered this is between a 10% and 25% speed increase. Existing tests add confidence this is non-breaking. New tests not required because these are optional flags. Validation this does not change is low consequence. Test update to exclude these config files from changelog requirements.
diff --git a/packages/animations/example/android/.pluginToolsConfig.yaml b/packages/animations/example/android/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/camera/camera/example/.pluginToolsConfig.yaml b/packages/camera/camera/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/camera/camera_android/example/.pluginToolsConfig.yaml b/packages/camera/camera_android/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/camera/camera_android_camerax/example/.pluginToolsConfig.yaml b/packages/camera/camera_android_camerax/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/dynamic_layouts/example/.pluginToolsConfig.yaml b/packages/dynamic_layouts/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/espresso/example/.pluginToolsConfig.yaml b/packages/espresso/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/extension_google_sign_in_as_googleapis_auth/example/.pluginToolsConfig.yaml b/packages/extension_google_sign_in_as_googleapis_auth/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/flutter_adaptive_scaffold/example/.pluginToolsConfig.yaml b/packages/flutter_adaptive_scaffold/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/flutter_markdown/example/.pluginToolsConfig.yaml b/packages/flutter_markdown/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/flutter_plugin_android_lifecycle/example/.pluginToolsConfig.yaml b/packages/flutter_plugin_android_lifecycle/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/go_router/example/.pluginToolsConfig.yaml b/packages/go_router/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/google_maps_flutter/google_maps_flutter/example/.pluginToolsConfig.yaml b/packages/google_maps_flutter/google_maps_flutter/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/google_maps_flutter/google_maps_flutter_android/example/.pluginToolsConfig.yaml b/packages/google_maps_flutter/google_maps_flutter_android/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/google_sign_in/google_sign_in/example/.pluginToolsConfig.yaml b/packages/google_sign_in/google_sign_in/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/google_sign_in/google_sign_in_android/example/.pluginToolsConfig.yaml b/packages/google_sign_in/google_sign_in_android/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/image_picker/image_picker_android/example/.pluginToolsConfig.yaml b/packages/image_picker/image_picker_android/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/local_auth/local_auth/example/.pluginToolsConfig.yaml b/packages/local_auth/local_auth/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/local_auth/local_auth_android/example/.pluginToolsConfig.yaml b/packages/local_auth/local_auth_android/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/palette_generator/example/.pluginToolsConfig.yaml b/packages/palette_generator/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/path_provider/path_provider/example/.pluginToolsConfig.yaml b/packages/path_provider/path_provider/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/path_provider/path_provider_android/example/.pluginToolsConfig.yaml b/packages/path_provider/path_provider_android/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/pigeon/example/app/.pluginToolsConfig.yaml b/packages/pigeon/example/app/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/quick_actions/quick_actions/example/.pluginToolsConfig.yaml b/packages/quick_actions/quick_actions/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/quick_actions/quick_actions_android/example/.pluginToolsConfig.yaml b/packages/quick_actions/quick_actions_android/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/shared_preferences/shared_preferences/example/.pluginToolsConfig.yaml b/packages/shared_preferences/shared_preferences/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/shared_preferences/shared_preferences_android/example/.pluginToolsConfig.yaml b/packages/shared_preferences/shared_preferences_android/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/url_launcher/url_launcher/example/.pluginToolsConfig.yaml b/packages/url_launcher/url_launcher/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/url_launcher/url_launcher_android/example/.pluginToolsConfig.yaml b/packages/url_launcher/url_launcher_android/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/video_player/video_player/example/.pluginToolsConfig.yaml b/packages/video_player/video_player/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/video_player/video_player_android/example/.pluginToolsConfig.yaml b/packages/video_player/video_player_android/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/webview_flutter/webview_flutter/example/.pluginToolsConfig.yaml b/packages/webview_flutter/webview_flutter/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/packages/webview_flutter/webview_flutter_android/example/.pluginToolsConfig.yaml b/packages/webview_flutter/webview_flutter_android/example/.pluginToolsConfig.yaml
@@ -0,0 +1,4 @@
+buildFlags:
+  _pluginToolsConfigGlobalKey:
+    - "--no-tree-shake-icons"
+    - "--dart-define=buildmode=testing"
diff --git a/script/tool/lib/src/common/package_state_utils.dart b/script/tool/lib/src/common/package_state_utils.dart
@@ -195,6 +195,7 @@ bool _isExampleBuildFile(List<String> pathComponents) {
       pathComponents.contains('build.gradle') ||
       pathComponents.contains('Runner.xcodeproj') ||
       pathComponents.contains('CMakeLists.txt') ||
+      pathComponents.contains('.pluginToolsConfig.yaml') ||
       pathComponents.contains('pubspec.yaml');
 }
 
diff --git a/script/tool/test/version_check_command_test.dart b/script/tool/test/version_check_command_test.dart
@@ -874,6 +874,7 @@ tool/plugin/lib/plugin.dart
         processRunner.mockProcessesForExecutable['git-diff'] =
             <FakeProcessInfo>[
           FakeProcessInfo(MockProcess(stdout: '''
+packages/plugin/example/android/.pluginToolsConfig.yaml
 packages/plugin/example/android/lint-baseline.xml
 packages/plugin/example/android/src/androidTest/foo/bar/FooTest.java
 packages/plugin/example/ios/RunnerTests/Foo.m
