Skip to content

Current Page Missing in ‘Change Page’ on Mobile Sub-Articles #7646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
avivkeller opened this issue Apr 12, 2025 · 1 comment · May be fixed by #7871
Open

Current Page Missing in ‘Change Page’ on Mobile Sub-Articles #7646

avivkeller opened this issue Apr 12, 2025 · 1 comment · May be fixed by #7871
Assignees
@manishprivet
Labels
learn Issues/pr concerning the learn section

Comments

@avivkeller
Copy link
Member

avivkeller commented Apr 12, 2025 •
edited
Loading

On smaller screens, such as mobile devices, the sidebar is replaced by a navigation menu accessible through the “Change Page” option. However, when viewing a sub-article, or any article not listed in the navigation menu, the area that typically displays the current page remains blank, likely because there is no corresponding entry.

Image Ref: https://nodejs.org/en/learn/diagnostics/memory/using-heap-profiler
@avivkeller avivkeller added the learn Issues/pr concerning the learn section label Apr 12, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Node.js Website Apr 12, 2025
@ovflowd
Copy link
Member

ovflowd commented Apr 24, 2025

It's strange that it was supposed to work as expected, but it didn't. Since people contributed to this piece over time, I imagine it got broken along the way.

manishprivet added a commit to manishprivet/nodejs.org that referenced this issue Jun 17, 2025
@manishprivet
fix(nodejs#7646): add default value if current page is missing in sid…
927d6b3 
…ebar

sometimes current page can be missing from navigation data if the entry is not present in the navigation.json file. In those cases it shows an empty select box on smaller screens. This PR chooses the first item in the navigation tree if the current page is missing from there
@manishprivet manishprivet linked a pull request Jun 17, 2025 that will close this issue
Open
5 tasks
@manishprivet manishprivet moved this from 📋 Backlog to 🏗 In progress in Node.js Website Jun 17, 2025
@manishprivet manishprivet self-assigned this Jun 17, 2025
manishprivet added a commit to manishprivet/nodejs.org that referenced this issue Jun 17, 2025
@manishprivet
refactor(nodejs#7646): update the select component to have a default …
aa5f1c6 
…placeholder of the window title in site
manishprivet added a commit to manishprivet/nodejs.org that referenced this issue Jun 17, 2025
@manishprivet
refactor(nodejs#7646): update the title source to that of frontmatter
4827696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manishprivet manishprivet

Labels
learn Issues/pr concerning the learn section
Projects
Node.js Website
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sidebar): use placeholders in select menu manishprivet/nodejs.org
3 participants
@ovflowd @avivkeller @manishprivet