-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(download): Devbox is not supported on Windows #7650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aviv Keller <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
ljharb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'd be nice to have a "WSL" option somehow prominent, so that windows users who have WSL can choose nvm, devbox, etc, but atm this seems good
|
Users running WSL should refer to the Linux instructions, as their environment is a Linux one. |
|
Are there snippets that need removing as part of this change? |
|
No, DevBox uses the same snippet for every operation system |
|
@avivkeller yes, but windows users may not realize WSL maps to linux, or may not realize WSL is an option. |
|
Lighthouse Results
|
|
We should move this discussion to an issue, but yeh, either we should update "Linux" to be "Linux (+ WSL)" or add a dedicated "WSL" option in the dropdown. Or, we could display a banner whenever Windows is selected noting that if the user is using WSL, they should refer to the Linux options. |
|
@ljharb It's in the name, Windows Subsystem for Linux. IMHO users should be expected to know that if they WSL, they can refer to the Linux instructions |
The whole point of this page is to not make assumptions, this page is for beginners that're new to Node.js (and often development generally). They may have heard that WSL is the thing to use for Windows dev, and not know anything beyond that. |
|
Yes, but windows users who are not using or aware of WSL won't know that WSL even exists as an option in the first place such that they could use the things listed under Linux. |
|
Feel free to open an issue / PR with whatever change you'd like to see |
|
#7651 👍 |
|
I'm fast tracking this, as we have several approvals, and it's unlikely we will get an objection |
DevBox is not supported on Windows without WSL. If you are using WSL, you should refer to the Linux instructions