Skip to content

Conversation

@avivkeller
Copy link
Member

DevBox is not supported on Windows without WSL. If you are using WSL, you should refer to the Linux instructions

Copilot AI review requested due to automatic review settings April 15, 2025 17:21
@avivkeller avivkeller requested a review from a team as a code owner April 15, 2025 17:21
@vercel
Copy link

vercel bot commented Apr 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 15, 2025 5:22pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'd be nice to have a "WSL" option somehow prominent, so that windows users who have WSL can choose nvm, devbox, etc, but atm this seems good

@avivkeller
Copy link
Member Author

Users running WSL should refer to the Linux instructions, as their environment is a Linux one.

@MattIPv4
Copy link
Member

Are there snippets that need removing as part of this change?

@avivkeller
Copy link
Member Author

No, DevBox uses the same snippet for every operation system

@ljharb
Copy link
Member

ljharb commented Apr 15, 2025

@avivkeller yes, but windows users may not realize WSL maps to linux, or may not realize WSL is an option.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
96.17% (176/183) 78.67% (107/136) 89.74% (35/39)
@nodejs/website Coverage: 87%
84.7% (493/582) 76.03% (165/217) 86.88% (106/122)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 31 0 💤 0 ❌ 0 🔥 5.741s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.997s ⏱️

@MattIPv4
Copy link
Member

MattIPv4 commented Apr 15, 2025

We should move this discussion to an issue, but yeh, either we should update "Linux" to be "Linux (+ WSL)" or add a dedicated "WSL" option in the dropdown. Or, we could display a banner whenever Windows is selected noting that if the user is using WSL, they should refer to the Linux options.

@avivkeller
Copy link
Member Author

@ljharb It's in the name, Windows Subsystem for Linux. IMHO users should be expected to know that if they WSL, they can refer to the Linux instructions

@MattIPv4
Copy link
Member

IMHO users should be expected to know that if they WSL, they can refer to the Linux instructions

The whole point of this page is to not make assumptions, this page is for beginners that're new to Node.js (and often development generally). They may have heard that WSL is the thing to use for Windows dev, and not know anything beyond that.

@ljharb
Copy link
Member

ljharb commented Apr 15, 2025

Yes, but windows users who are not using or aware of WSL won't know that WSL even exists as an option in the first place such that they could use the things listed under Linux.

@avivkeller
Copy link
Member Author

Feel free to open an issue / PR with whatever change you'd like to see

@MattIPv4
Copy link
Member

#7651 👍

@avivkeller avivkeller added the fast-track Fast Tracking PRs label Apr 15, 2025
@avivkeller
Copy link
Member Author

I'm fast tracking this, as we have several approvals, and it's unlikely we will get an objection

@avivkeller avivkeller enabled auto-merge April 15, 2025 20:14
@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Apr 15, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 15, 2025
@avivkeller avivkeller added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 47d583b Apr 15, 2025
28 checks passed
@avivkeller avivkeller deleted the fix/windows-devbox branch April 15, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants